Write event when admintools is deployed with a v24.2.0 server #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 20, 2024 19:10
The v24.2.0 server image, when built for vclusterops, will not work if admintools deployment is selected. This will surface an event message if we detect this is the case. This is important because the image will fail to run if this is the case. This is tied into the crashloop_reconciler.
roypaulin
reviewed
Feb 21, 2024
| func HasCreateContainerError(containerStatus *corev1.ContainerStatus) bool { | ||
| return containerStatus.State.Waiting != nil && | ||
| containerStatus.State.Waiting.Reason == "CreateContainerError" && | ||
| strings.Contains(containerStatus.State.Waiting.Message, "no command specified") |
There was a problem hiding this comment.
I guess there is no other reasons for CreateContainerError
There was a problem hiding this comment.
Not sure. I was looking specifically for the 'no command specified' error. So, that should reduce the chance of this hitting other scenarios we hadn't considered.
roypaulin
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v24.2.0 server image, when built for vclusterops, will not work if admintools deployment is selected. The container will fail to run. This will surface an event message if we detect this is the case. This is tied into the crashloop_reconciler.