Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support password encryption #224

Open
bangsun1234 opened this issue Nov 22, 2022 · 4 comments
Open

Support password encryption #224

bangsun1234 opened this issue Nov 22, 2022 · 4 comments
Labels
HACKTOBERFEST type/enhancement Type: make the code neat or more efficient

Comments

@bangsun1234
Copy link

In the production environment, the configuration file cannot contain plaintext passwords. The password needs to be encrypted. We need to use an encryption algorithm 'PBEWithHmacSHA256AndAES_256'.

@wey-gu
Copy link
Contributor

wey-gu commented Nov 22, 2022

Thanks @bangsun1234 we need to provide a secured way to pass the credential with importer(and other tooling).

cc @MuYiYong

@Sophie-Xie Sophie-Xie added type/enhancement Type: make the code neat or more efficient and removed enhancement labels Nov 29, 2022
@veezhang
Copy link
Contributor

@wey-gu Maybe env parameter is suitable? Configure it in config file is indeed less secure.
For example NG_PASSWORD or NEBULAGRAPH_PASSWORD.

And nebula-console have similar question.
@MuYiYong

@veezhang
Copy link
Contributor

@bangsun1234 Thank you!
I think it may not be appropriate to use an encryption algorithm, because the encrypted string can still connect to the database, so encryption is meaningless?

@wey-gu
Copy link
Contributor

wey-gu commented Nov 30, 2022

Maybe env parameter is suitable? Configure it in config file is indeed less secure.
For example NG_PASSWORD or NEBULAGRAPH_PASSWORD.

Agreed 👍🏻 @veezhang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HACKTOBERFEST type/enhancement Type: make the code neat or more efficient
Projects
Development

No branches or pull requests

4 participants