Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.6.1 patch] Refactor connection pool and add more tests #251

Merged
merged 2 commits into from
Dec 13, 2022

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Dec 12, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Address some common issues along with #247:

  1. Refactor code of the connection pool to simplify the implementation and print more user-friendly logs
  2. Remove unusable connection if connection Ping() failed
  3. Add automated test cases regarding the problem above

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@Aiee Aiee changed the title Add more tests Refactor connection pool and add more tests Dec 13, 2022
@Aiee Aiee changed the title Refactor connection pool and add more tests [v2.6.1 patch] Refactor connection pool and add more tests Dec 13, 2022
Lower concurrence for ci so the github action can pass
@yixinglu yixinglu merged commit ef9e8d5 into vesoft-inc:v2.6.1 Dec 13, 2022
@Aiee Aiee deleted the v2.6.1 branch December 13, 2022 09:42
Aiee added a commit to Aiee/nebula-python that referenced this pull request Jan 11, 2023
…c#251)

* Add more tests

* Tune tests and refactor

Lower concurrence for ci so the github action can pass
Aiee added a commit that referenced this pull request Jan 11, 2023
* [DO NOT MERGE] Remove unusable connection if connection Ping() failed (#247)

* rRemove unusable connection if connectino Ping() failed

* Fix typo

* [v2.6.1 patch] Refactor connection pool and add more tests (#251)

* Add more tests

* Tune tests and refactor

Lower concurrence for ci so the github action can pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants