-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support publish docs to readthedocs #292
Conversation
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #292 +/- ##
=======================================
Coverage 77.97% 77.97%
=======================================
Files 18 18
Lines 2415 2415
=======================================
Hits 1883 1883
Misses 532 532 ☔ View full report in Codecov by Sentry. |
Amazing! Was about to be on a long flight, will apply for it ASAP when I am available!
@liuxiaocs7 done with slug nebulagraph-python, I'll PR to adjust that accordingly :) |
can we just expose the api in module nebula3.gclient? the thrift api is useless for users. |
Exclude some dirs by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great job!
* chore: read the doc slug update ref: #292 * chore: wording of the docs
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
close: #289
Description:
Hi, @wey-gu, plz help create project plug named
nebula-python
in readthedocs, and enable this option.I have tested locally:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: