Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show default zone and default group #2852

Closed
HarrisChu opened this issue Sep 13, 2021 · 9 comments
Closed

show default zone and default group #2852

HarrisChu opened this issue Sep 13, 2021 · 9 comments
Assignees
Labels
need to discuss Solution: issue or PR without a clear conclusion on whether to handle it type/feature req Type: feature request
Milestone

Comments

@HarrisChu
Copy link
Contributor

there are some concerns about default zone.

  1. if user upgrade from 2.0.1

    • a storage with partitions should be in a default zone and default group?
    • how about a storage without partitions. e.g. balance remove
  2. if user creates space without group.

    • a storage with partitions should be in a default zone and default group?
    • how about a storage without partitions

it's better to show the default zone and default group, and explain the logic how we consider a storage in default zone or not.

@HarrisChu HarrisChu added this to the v2.6.0 milestone Sep 13, 2021
@HarrisChu HarrisChu added the type/feature req Type: feature request label Sep 13, 2021
@Sophie-Xie
Copy link
Contributor

@critical27 @darionyaphet pls discuss this requirement, is it need be resolved in v2.6.0?

@HarrisChu
Copy link
Contributor Author

(root@nebula) [nba]> desc space nba;
+----+-------+------------------+----------------+---------+------------+---------------------+-------------+-----------+---------+
| ID | Name  | Partition Number | Replica Factor | Charset | Collate    | Vid Type            | Atomic Edge | Group     | Comment |
+----+-------+------------------+----------------+---------+------------+---------------------+-------------+-----------+---------+
| 1  | "nba" | 100              | 1              | "utf8"  | "utf8_bin" | "FIXED_STRING(128)" | false       | "default" |         |
+----+-------+------------------+----------------+---------+------------+---------------------+-------------+-----------+---------+
Got 1 rows (time spent 945/7564 us)

Tue, 14 Sep 2021 15:03:10 CST

(root@nebula) [nba]> show groups
+------+------+
| Name | Zone |
+------+------+
+------+------+
Empty set (time spent 1253/7305 us)

Tue, 14 Sep 2021 15:05:02 CST

more information

@critical27
Copy link
Contributor

critical27 commented Sep 14, 2021

You mean show groups return a default group by default? But I can't figure out how to fill the Zone field...

@HarrisChu
Copy link
Contributor Author

You mean show groups return a default group by default? But I can't figure out how to fill the Zone field...

Yes, that's also my question... If we figure out the zone with default zone, how we consider which storage belongs to the default zone?

We could have a discussion.

@critical27
Copy link
Contributor

We discuss on a meeting, by default we return: (suppose we have n hosts before)

default group: [all hosts previously, each host is a zone]
zone 1: [old host 1]
...
zone n: [old host n]

WDYT?

@darionyaphet
Copy link
Contributor

You mean show groups return a default group by default? But I can't figure out how to fill the Zone field...

Show default group may be a good idea. I agree with you

@critical27
Copy link
Contributor

critical27 commented Sep 15, 2021

Talked offline with @darionyaphet , we'll print default group when exec show groups command, each host will be a separate zone. This is quite reasonable.

But I don't know whether we need to print the host in each default zone(which is the host itself)

@Sophie-Xie Sophie-Xie added the need to discuss Solution: issue or PR without a clear conclusion on whether to handle it label Sep 16, 2021
@critical27
Copy link
Contributor

Talked offline, will not support this interface until 3.0. Because a host could both belongs to a default zone and a user create zone, which breaks the invariant.

@HarrisChu
Copy link
Contributor Author

Talked offline, will not support this interface until 3.0. Because a host could both belongs to a default zone and a user create zone, which breaks the invariant.

agree and then close issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need to discuss Solution: issue or PR without a clear conclusion on whether to handle it type/feature req Type: feature request
Projects
None yet
Development

No branches or pull requests

4 participants