-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to cancel unflipping #9
Comments
Seconded. We would like to use this addon, but need this feature first. Do you need any help with this? I can PR if that speeds it up. |
I'm busy right now and have no time to implement this, so if you have time feel free to PR that. Current implementation is kinda "lazy", if server sees it has enough people it just schedules the unflip after certain time and forces people to stay still for that time. (it could use an animation too) Contributions always welcome! |
Working on it, concept so far is:
Currently having trouble differentiating between different progressBar failure modes. User who hit ESC is supposed to send unflip_stop event to server. Users who did not hit ESC, but are aborted, because _requiredUnits threshold is no longer met, should not send unflip_stop event. The needed error code argument will hopefully be added in the next CBA release. |
Concept logic seems solid for me. 👌 |
Needs to be done if unflipping time option would allow bigger values.
The text was updated successfully, but these errors were encountered: