Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CoreDNS image cannot be pulled when use custom registry as kubernetes_image_repository #30

Closed
cuttingedge1109 opened this issue Jun 27, 2023 · 4 comments · Fixed by #66

Comments

@cuttingedge1109
Copy link
Contributor

kubernetes/kubeadm#2714

@mnaser
Copy link
Member

mnaser commented Jun 27, 2023

@cuttingedge1109: thanks for the bug report, I think we already have use cases where we are actually accomodating for the fact that coredns images are all at a weird path.

since it would be an api breaking change if we made that change, do you think you it makes sense for us to have overrides available instead so you can override the kubeadm config?

@cuttingedge1109
Copy link
Contributor Author

cuttingedge1109 commented Jul 5, 2023

@cuttingedge1109: thanks for the bug report, I think we already have use cases where we are actually accomodating for the fact that coredns images are all at a weird path.

since it would be an api breaking change if we made that change, do you think you it makes sense for us to have overrides available instead so you can override the kubeadm config?

yeap, that will work also

@mnaser
Copy link
Member

mnaser commented Oct 13, 2023

@cuttingedge1109 I believe this shouldn't be needed now cause all images will have that direct path under the kubernetes_image_repository -- so I think you should be good to g?

@cuttingedge1109
Copy link
Contributor Author

@cuttingedge1109 I believe this shouldn't be needed now cause all images will have that direct path under the kubernetes_image_repository -- so I think you should be good to g?

@mnaser sorry for my late response.
I suggest setting coredns repository explicitly with subpath respecting the kubernetes official document. It worked well for our all private clusters. Here is a pull request.
#66

@mnaser mnaser closed this as completed in #66 Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants