Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance no longer created using the "-control-plane-" convention. #400

Closed
hlesesne opened this issue Jun 21, 2024 · 4 comments
Closed

Instance no longer created using the "-control-plane-" convention. #400

hlesesne opened this issue Jun 21, 2024 · 4 comments

Comments

@hlesesne
Copy link

This may have been intentional, but I didn't find it any the release notes. It appears that previous versions used the convention:

kube-string-string-control-plane-string for control planes and kube-string-string-default-worker-string for worker nodes.

Now it appears that control planes have dropped the -control-plane- convention, so instance names are kube-string-string-string. Worker nodes continue to use the -default-worker- convention.

This isn't a big deal at all, but I discovered it in a small test script that steps up a ssl proxy to the control plane and it looked for -control-plane- in the name. It's an easy fix in my script, but I wanted to mention it, just in case it was a regression and not intended.

@hlesesne
Copy link
Author

getting_started.md does seem to still reference the convention:

kube-7kjbp-control-plane-vxtrz-nhjr2 Ready control-plane,master 3d v1.25.3

@mnaser
Copy link
Member

mnaser commented Jun 22, 2024

Hmm.. it seem that this change at some point probably with CAPI, let me see..

@mnaser
Copy link
Member

mnaser commented Jun 22, 2024

I think this change happened when CAPI introduced kubernetes-sigs/cluster-api#9340 and not within the scope of the Cluster API but I'll dig in more.

@mnaser
Copy link
Member

mnaser commented Jun 26, 2024

I believe this has nothing to do with the Cluster API, I think this is to do with a Cluster API update that you might have done at your side with the latest update that may have done that change.

@mnaser mnaser closed this as not planned Won't fix, can't repro, duplicate, stale Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants