Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more SGR decorations in ControlBuilder? #67

Closed
alexrp opened this issue Jan 1, 2022 · 1 comment
Closed

Support more SGR decorations in ControlBuilder? #67

alexrp opened this issue Jan 1, 2022 · 1 comment
Labels
area: samples Issues related to the sample projects. area: sequences Issues related to the control sequence APIs.
Milestone
v1.0

Comments

@alexrp
Copy link
Member

alexrp commented Jan 1, 2022

Address this comment one way or another:

https://github.com/alexrp/system-terminal/blob/c502da648694c720e058150256d4b9ac000a078c/src/core/Text/Control/ControlBuilder.cs#L604-L614
@alexrp alexrp added type: feature state: deliberation Issues that require design work and/or discussion. area: samples Issues related to the sample projects. area: sequences Issues related to the control sequence APIs. labels Jan 1, 2022
@alexrp alexrp added this to the v1.0 milestone Jan 1, 2022
@alexrp alexrp self-assigned this Jan 1, 2022
@alexrp
Copy link
Member Author

alexrp commented Jan 2, 2022

AFAICT, the only useful decorations we're missing support for are kitty's decorated underlines: https://sw.kovidgoyal.net/kitty/underlines

It appears to be supported by at least kitty, VTE, mintty, iTerm2, and WezTerm. There are also plans to support it in Windows Terminal.

@alexrp alexrp closed this as completed in fbf1ec1 Jan 2, 2022
@alexrp alexrp added state: resolved and removed state: deliberation Issues that require design work and/or discussion. labels Jan 2, 2022
@alexrp alexrp removed their assignment Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: samples Issues related to the sample projects. area: sequences Issues related to the control sequence APIs.
Milestone
v1.0
Development

No branches or pull requests
1 participant
@alexrp