Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ControllerConfig outdated #2

Open
dvgitit opened this issue Mar 8, 2024 · 3 comments
Open

ControllerConfig outdated #2

dvgitit opened this issue Mar 8, 2024 · 3 comments

Comments

@dvgitit
Copy link

dvgitit commented Mar 8, 2024

replace with current implementation

@krin-wang
Copy link

@dvgitit could u pls explain a bit more? Is this related to #3? thx.

@dvgitit
Copy link
Author

dvgitit commented Mar 15, 2024

@dvgitit could u pls explain a bit more? Is this related to #3? thx.

It is more or less just a note that DeploymentRuntimeConfig replaces Controller config. Nevertheless, this example repo is very good.

ControllerConfig is the CRD type for a packaged controller configuration. Deprecated: This API is replaced by DeploymentRuntimeConfig, and is scheduled to be removed in a future release. See the design doc for more details: https://github.com/crossplane/crossplane/blob/11bbe13ea3604928cc4e24e8d0d18f3f5f7e847c/design/one-pager-package-runtime-config.md

Source: https://doc.crds.dev/github.com/crossplane/crossplane/pkg.crossplane.io/ControllerConfig/v1alpha1

@vfarcic
Copy link
Owner

vfarcic commented Mar 15, 2024

@krin-wang Those are not related. DeploymentRuntimeConfig replaces ControllerConfig. It's a better (more flexible) way to define config for a provider which I did not use so far mostly to avoid potential compatibility issues with older Crossplane. For now, both are working and will continue working for a while. I will, eventually, rewrite manifests to use DeploymentRuntimeConfig but, for now, that should not be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants