-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement vibe.core.process for subprocess handling similar to std.process #154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks nice, apart from the naming questions this looks good to go. Great to have this missing piece of the puzzle integrated now. I hope to get to the Windows implementation soon...
Thanks for the review @s-ludwig, it would also be good to merge this: vibe-d/eventcore#110, as it causes some bugs in this code |
Thanks again! Looks good to merge now. I'll add tag a new alpha tag afterwards (or maybe even beta). |
Thanks for merging this! Looking forward to using this in my projects :) |
I've tried to keep most of the features of std.process, if there's anything big I missed let me know.
The tests are simple ports from supervised. They don't have full coverage, but the core should be solid.