Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional timeout parameter to resolveHost #220

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Add optional timeout parameter to resolveHost #220

merged 1 commit into from
Aug 19, 2020

Conversation

AndrejMitrovic
Copy link
Contributor

I'm not sure how to write a test-case for this though.

@AndrejMitrovic
Add optional timeout parameter to resolveHost
f2c6cea 
This will be useful in e.g. the client,
which uses connection timeouts but does not use
any timeout for resolving the host as of yet.
This was referenced Aug 19, 2020
Merged
Closed
@AndrejMitrovic
Copy link
Contributor Author

The appveryor failures seem unrelated. Is the test-suite known to be flakey?

@AndrejMitrovic
Copy link
Contributor Author

Also Travis:

Test failed: core.exception.AssertError@tests/dirwatcher.d(51): Change is not what was expected, got: [DirectoryChange(modified, /var/folders/nz/vv4_9tw56nv9k3tkvyszvwg80000gn/T/dirwatcher_test_2321/foo), DirectoryChange(removed, /var/folders/nz/vv4_9tw56nv9k3tkvyszvwg80000gn/T/dirwatcher_test_2321/foo), DirectoryChange(added, /var/folders/nz/vv4_9tw56nv9k3tkvyszvwg80000gn/T/dirwatcher_test_2321/subdir/bar), DirectoryChange(modified, /var/folders/nz/vv4_9tw56nv9k3tkvyszvwg80000gn/T/dirwatcher_test_2321/subdir/bar), DirectoryChange(removed, /var/folders/nz/vv4_9tw56nv9k3tkvyszvwg80000gn/T/dirwatcher_test_2321/subdir/bar)] but expected: [DirectoryChange(added, /var/folders/nz/vv4_9tw56nv9k3tkvyszvwg80000gn/T/dirwatcher_test_2321/foo), DirectoryChange(modified, /var/folders/nz/vv4_9tw56nv9k3tkvyszvwg80000gn/T/dirwatcher_test_2321/foo), DirectoryChange(removed, /var/folders/nz/vv4_9tw56nv9k3tkvyszvwg80000gn/T/dirwatcher_test_2321/foo), DirectoryChange(added, /var/folders/nz/vv4_9tw56nv9k3tkvyszvwg80000gn/T/dirwatcher_test_2321/subdir/bar), DirectoryChange(modified, /var/folders/nz/vv4_9tw56nv9k3tkvyszvwg80000gn/T/dirwatcher_test_2321/subdir/bar), DirectoryChange(removed, /var/folders/nz/vv4_9tw56nv9k3tkvyszvwg80000gn/T/dirwatcher_test_2321/subdir/bar)]

This seems unrelated to me..

@Geod24
Copy link
Contributor

Geod24 commented Aug 19, 2020

It is, the testsuite for this project is more flakey than Agora's...

@s-ludwig
Copy link
Member

It's really annoying because those tests only fail on the CI infrastructure and remote debugging there is not exactly the most efficient thing in the world. I'll have to dedicate some time to fix this - sometime.

I'll merge manually.

@s-ludwig s-ludwig merged commit 11a42dc into vibe-d:master Aug 19, 2020
@AndrejMitrovic AndrejMitrovic deleted the add-timeout branch August 19, 2020 08:52
@Geod24
Copy link
Contributor

Geod24 commented Aug 19, 2020

@s-ludwig : The solution is #221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Geod24 Geod24 Geod24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrejMitrovic @Geod24 @s-ludwig