Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make LocalTaskSemaphore.this nothrow #259

Merged
merged 2 commits into from
Mar 15, 2021
Merged

Make LocalTaskSemaphore.this nothrow #259

merged 2 commits into from
Mar 15, 2021

Conversation

Geod24
Copy link
Contributor

@Geod24 Geod24 commented Mar 15, 2021 

vibe-core ~master: building configuration "vibe-core-test-cfrunloop"...
source/vibe/core/sync.d(214,2): Deprecation: `vibe.core.sync.LocalTaskSemaphore.this` has stricter attributes than its destructor (`@system`)
source/vibe/core/sync.d(214,2):        The destructor will be called if an exception is thrown
source/vibe/core/sync.d(214,2):        Either make the constructor `nothrow` or adjust the field destructors

@Geod24 Geod24 force-pushed the fix-regression branch 2 times, most recently from e53e626 to 2015e72 Compare March 15, 2021 11:59
@Geod24
Copy link
Contributor Author

Geod24 commented Mar 15, 2021

@s-ludwig : Weirdly, this is still failing (?)

@s-ludwig
Copy link
Member

I could modify the test to always catch the issue and opened a PR: #262

@Geod24
CI: Disable fail-fast to get a full run
8b5a432 
The CI is pretty quick, and we don't want things cancelled as soon
as one row fails, as we test multiple compiler versions accross
multiple platforms.
@Geod24
Make LocalTaskSemaphore.this nothrow
f2cd18f 
Silence a (rightful) deprecation from v2.096.0.
@Geod24
Copy link
Contributor Author

Geod24 commented Mar 15, 2021

Thanks! I rebased.

eventcore 0.9.13: building configuration "winapi"...
C:\Users\runneradmin\AppData\Local\dub\packages\eventcore-0.9.13\eventcore\.dub\build\winapi-unittest-windows-x86_64-dmd_2085-F00DFB13E568032DBF8EF047EEC6F61B\eventcore.lib: Error: MS-Coff object module `core.obj` has magic = 6050, should be 8664
C:\Users\runneradmin\AppData\Local\dub\packages\eventcore-0.9.13\eventcore\.dub\build\winapi-unittest-windows-x86_64-dmd_2085-F00DFB13E568032DBF8EF047EEC6F61B\eventcore.lib: Error: MS-Coff object module `core_1_48e.obj` has magic = 6050, should be 8664
C:\Users\runneradmin\AppData\Local\dub\packages\eventcore-0.9.13\eventcore\.dub\build\winapi-unittest-windows-x86_64-dmd_2085-F00DFB13E568032DBF8EF047EEC6F61B\eventcore.lib: Error: MS-Coff object module `driver.obj` has magic = 6050, should be 8664
C:\Users\runneradmin\AppData\Local\dub\packages\eventcore-0.9.13\eventcore\.dub\build\winapi-unittest-windows-x86_64-dmd_2085-F00DFB13E568032DBF8EF047EEC6F61B\eventcore.lib: Error: MS-Coff object module `driver_2_e01.obj` has magic = 6050, should be 8664
C:\Users\runneradmin\AppData\Local\dub\packages\eventcore-0.9.13\eventcore\.dub\build\winapi-unittest-windows-x86_64-dmd_2085-F00DFB13E568032DBF8EF047EEC6F61B\eventcore.lib: Error: MS-Coff object module `driver_3_f8a.obj` has magic = 6050, should be 8664
C:\Users\runneradmin\AppData\Local\dub\packages\eventcore-0.9.13\eventcore\.dub\build\winapi-unittest-windows-x86_64-dmd_2085-F00DFB13E568032DBF8EF047EEC6F61B\eventcore.lib: Error: MS-Coff object module `driver_4_10dd.obj` has magic = 6050, should be 8664
C:\Users\runneradmin\AppData\Local\dub\packages\eventcore-0.9.13\eventcore\.dub\build\winapi-unittest-windows-x86_64-dmd_2085-F00DFB13E568032DBF8EF047EEC6F61B\eventcore.lib: Error: MS-Coff object module `driver_5_ee6.obj` has magic = 6050, should be 8664
C:\Users\runneradmin\AppData\Local\dub\packages\eventcore-0.9.13\eventcore\.dub\build\winapi-unittest-windows-x86_64-dmd_2085-F00DFB13E568032DBF8EF047EEC6F61B\eventcore.lib: Error: MS-Coff object module `driver_6_ff4.obj` has magic = 6050, should be 8664
C:\Users\runneradmin\AppData\Local\dub\packages\eventcore-0.9.13\eventcore\.dub\build\winapi-unittest-windows-x86_64-dmd_2085-F00DFB13E568032DBF8EF047EEC6F61B\eventcore.lib: Error: MS-Coff object module `driver_7_1076.obj` has magic = 6050, should be 8664
C:\Users\runneradmin\AppData\Local\dub\packages\eventcore-0.9.13\eventcore\.dub\build\winapi-unittest-windows-x86_64-dmd_2085-F00DFB13E568032DBF8EF047EEC6F61B\eventcore.lib: Error: MS-Coff object module `driver_8_10d2.obj` has magic = 6050, should be 8664
C:\Users\runneradmin\AppData\Local\dub\packages\eventcore-0.9.13\eventcore\.dub\build\winapi-unittest-windows-x86_64-dmd_2085-F00DFB13E568032DBF8EF047EEC6F61B\eventcore.lib: Error: MS-Coff object module `driver_9_1075.obj` has magic = 6050, should be 8664
C:\Users\runneradmin\AppData\Local\dub\packages\eventcore-0.9.13\eventcore\.dub\build\winapi-unittest-windows-x86_64-dmd_2085-F00DFB13E568032DBF8EF047EEC6F61B\eventcore.lib: Error: MS-Coff object module `driver_a_1142.obj` has magic = 6050, should be 8664
C:\Users\runneradmin\AppData\Local\dub\packages\eventcore-0.9.13\eventcore\.dub\build\winapi-unittest-windows-x86_64-dmd_2085-F00DFB13E568032DBF8EF047EEC6F61B\eventcore.lib: Error: MS-Coff object module `driver_b_11b8.obj` has magic = 6050, should be 8664
C:\Users\runneradmin\AppData\Local\dub\packages\eventcore-0.9.13\eventcore\.dub\build\winapi-unittest-windows-x86_64-dmd_2085-F00DFB13E568032DBF8EF047EEC6F61B\eventcore.lib: Error: MS-Coff object module `driver_c_1002.obj` has magic = 6050, should be 8664
C:\Users\runneradmin\AppData\Local\dub\packages\eventcore-0.9.13\eventcore\.dub\build\winapi-unittest-windows-x86_64-dmd_2085-F00DFB13E568032DBF8EF047EEC6F61B\eventcore.lib: Error: MS-Coff object module `driver_d_3e3.obj` has magic = 6050, should be 8664
C:\Users\runneradmin\AppData\Local\dub\packages\eventcore-0.9.13\eventcore\.dub\build\winapi-unittest-windows-x86_64-dmd_2085-F00DFB13E568032DBF8EF047EEC6F61B\eventcore.lib: Error: MS-Coff object module `driver_e_8f1.obj` has magic = 6050, should be 8664
C:\Users\runneradmin\AppData\Local\dub\packages\eventcore-0.9.13\eventcore\.dub\build\winapi-unittest-windows-x86_64-dmd_2085-F00DFB13E568032DBF8EF047EEC6F61B\eventcore.lib: Error: MS-Coff object module `driver_f_b74.obj` has magic = 6050, should be 8664
C:\Users\runneradmin\AppData\Local\dub\packages\eventcore-0.9.13\eventcore\.dub\build\winapi-unittest-windows-x86_64-dmd_2085-F00DFB13E568032DBF8EF047EEC6F61B\eventcore.lib: Error: MS-Coff object module `driver_10_b65.obj` has magic = 6050, should be 8664
C:\Users\runneradmin\AppData\Local\dub\packages\eventcore-0.9.13\eventcore\.dub\build\winapi-unittest-windows-x86_64-dmd_2085-F00DFB13E568032DBF8EF047EEC6F61B\eventcore.lib: Error: MS-Coff object module `driver_11_6e2.obj` has magic = 6050, should be 8664
C:\Users\runneradmin\AppData\Local\dub\packages\eventcore-0.9.13\eventcore\.dub\build\winapi-unittest-windows-x86_64-dmd_2085-F00DFB13E568032DBF8EF047EEC6F61B\eventcore.lib: Error: MS-Coff object module `driver_12_75a.obj` has magic = 6050, should be 8664

... And I think the CI just hates me.

@Geod24
Copy link
Contributor Author

Geod24 commented Mar 15, 2021

Self merging as it's trivial and the last piece missing for a new release.

@Geod24 Geod24 merged commit c1e3f2d into vibe-d:master Mar 15, 2021
@Geod24 Geod24 deleted the fix-regression branch March 15, 2021 16:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Geod24 @s-ludwig