Add shared overloads of most mutex/condition methods #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to properly construct Task(Mutex/Condition) objects as shared in order to pass them between threads. A major part missing for the longer term is replacing the current non-shared "Lockable" interface with a shared (and partially nothrow) one, but this will require backwards-incompatible changes.
s-ludwig
force-pushed
the
shared_sync_api
branch
from
622a283
to
2d2c205
Compare
l-kramer
approved these changes
Mar 31, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to properly construct
Task(Mutex/Condition)objects as shared in order to pass them between threads. A major part missing for the longer term is replacing the current non-shared"Lockable" interface with ashared(and partiallynothrow) one, but this will require backwards-incompatible changes. This will then also remove the need for the@trustedconversions.