Fix lazy evaluation of log arguments #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-ludwig
force-pushed
the
fix_lazy_log_evaluation
branch
from
6d4eda7
to
a1afa99
Compare
| if (!getLoggers().any!(l => l.minLevel <= level)) | ||
| return; | ||
|
|
||
| T args_copy = args; |
There was a problem hiding this comment.
won't compile because if T.length == 0 args_copy is undefined
There was a problem hiding this comment.
But this is inside of static if (T.length != 0) { ... }, so it should still work.
There was a problem hiding this comment.
Ah, I see, my fork is stuck in an old version where formattedWrite is not in static if block
l-kramer
approved these changes
Apr 18, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes vibe-d/vibe-http#36