v2 questions

[bre7]

1. Typo in the definition ? It's in the #pragma mark - Class Methods section
2. In UIViewController+Chameleon.h the method flatify() is empty (Line 97)
3. In findColorsOfImage(...), won't the NSArray and NSCountedSet have the same colors ?

[vicc]

@bre7

1. In what file is the typo in? Ohh you're referring to the Instance Method in that section. Got it! Will fix it in the next version thanks!
2. I ended up removing support for the flatify method. It wasn't as perfect as I wanted it to be, and with the new support for themes, I figured it wouldn't be as useful.
3. Not exactly. The NSCountedSet holds a color for every single pixel. I then do some processing (ensure they all have a minimum saturation tolerance) and sort them by most occuring to least occuring. Eventually only 5 will end up in the NSArray.

[bre7]

I think 1 was in one of the categories named Private.

Tests incoming also. I'll start with your code as a baseline for now.

[bre7]

if (abs(r - g < 0.03f && fabs(r - b) < 0.03f)) {

abs of a bool ?

[vicc]

Where is that line located?

[bre7]

https://github.com/ViccAlexander/Chameleon/blob/338ff86ed7a8f8cf0fed578215742605a67391ce/Pod/Classes/Objective-C/UIColor%2BChameleonPrivate.m#L103

[vicc]

Oh right. abs isn't a bool. What that line is doing is checking if a certain color is distinct enough from another. Specifically, it is checking if the difference of several values is at least 0.03 (tolerance). If it is, it determines that the two colors are distinct, otherwise it returns no. It does this several times checking for different things each time.

[bre7]

1. Shouldn't UIColor.blueColor().flatten() be the same as FlatBlue() or FlatBlueDark() ? Or should nearestColor return another thing ? Or is flatten supposed to compute a flat version of the color, without taking into account the FlatColors array ?
2. One other thing, shouldn't flatten() call UIColor(flatVersionOf: color, withAlpha: color.alpha) instead of UIColor(flatVersionOf: color, withAlpha: 1.0) ?

[vicc]

1. Yes and no. What it does is it tries to find the closest "Flat Color" to the provided color. 'Flattening' blue has always been a bit of a problem since the human eye tends to favor it differently than computers, so it usually returns a purplish flat for that specific blue. It worked exactly the same as the deprecatedflatVersionOf: method.
2. Ahh you're right! Nice catch!

[bre7]

1. Why have a separate parameter for alpha instead of using color's alpha, in + (UIColor *)colorWithComplementaryFlatColorOf:(UIColor *)color withAlpha:(CGFloat)alpha
2. Why does complementaryFlatColor(..) calculate the color using the gradient image ? Nvm, got it
3. gradientImage is supposed to be an optional asset set by the dev, right ?
4. if (abs(r - g < 0.03f && fabs(r - b) < 0.03f)) again. I'm still not sure why abs(boolValue) is working since abs expects an Int (or other numeric type...abs(0) = 0 in which case why even use abs ?)

[vicc]

1. To answer your first question, I figured it would be easier for developers who also wanted to change the alpha of the new color, to do so in one call. I've found myself having to do that a few times, and so this definitely made that easier. However I'm sure you've seen it, but there's also a simple version of that method: + (UIColor *)colorWithComplementaryFlatColorOf:(UIColor *)color
2. Glad you figured it out! 😃
3. Actually gradientImage is a property added to UIImage to hold the gradient a user creates when using colorWithGradient... It's not meant to be directly set by the user (More like a storage area for Chameleon). If anything it should be readonly though. I'll update it.
4. Let me take a look and I'll get back to you on this!

[vicc]

@bre7 Seeing how much you've helped out in the past few weeks, I've added you as a collaborator to make things easier! Thanks for all your help 💯 😃

[bre7]

😉😁 ty. I've enjoyed working with this framework quite a lot

I usually don't merge anything (unless it's minor) until the owner has a chance to check it out.

[vicc]

No worries! I trust your input. 👍

[jlama]

Shouldn't if (abs(r - g < 0.03f && fabs(r - b) < 0.03f)) actually be if (fabs(r - g) < 0.03f && fabs(r - b) < 0.03f) ?

[vicc]

@jlama At first glance it looks like your suggestion should be used, but apparently Xcode throws the following warning if we do that:

/Users/...UIColor+ChameleonPrivate.m:103:13: Using floating point absolute value function 'fabs' when argument is of integer type

That is why we're using abs instead of fabs.

[jlama]

Xcode throws that warning because the whole expression inside fabs() always evaluates to a boolean, due to the parentheses position, and does not make any sense.

What I wanted to point out is the missing closing ) after abs(r - g
if (abs(r - g < 0.03f && fabs(r - b) < 0.03f))
vs
if (fabs(r - g) < 0.03f && fabs(r - b) < 0.03f)

[vicc]

Ahh I see. Thanks @jlama. It seems that as of 2.0.4 it's been fixed. Appreciate it though.

[jlama]

It doesn't seem so: https://github.com/ViccAlexander/Chameleon/blob/master/Pod/Classes/Objective-C/UIColor%2BChameleonPrivate.m#L103

[vicc]

Oh wow you're right. It should be fixed in 2.0.5.