Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recheck, cover tests, actualize and document disposable's related logic #666

Closed
victimsnino opened this issue Oct 16, 2024 · 1 comment
Closed

Recheck, cover tests, actualize and document disposable's related logic #666

victimsnino opened this issue Oct 16, 2024 · 1 comment
Milestone
2.2.0

Comments

@victimsnino
Copy link
Owner

victimsnino commented Oct 16, 2024 •
edited
Loading

Maybe revert https://github.com/victimsnino/ReactivePlusPlus/pull/640/files
#662 this one is incorrect partially
Rewrite this one https://discord.com/channels/1014882683895156757/1014882910802804766/1295830271500750898

Currently disposables could be a bit non-intuitive and can be interpreted as subscription but actually they are not. It should be documented properly
@victimsnino victimsnino mentioned this issue Oct 17, 2024
Merged
@victimsnino victimsnino added this to the 2.2.0 milestone Nov 2, 2024
@coderabbitai coderabbitai bot mentioned this issue Nov 3, 2024
Merged
@victimsnino
Copy link
Owner Author

victimsnino commented Nov 6, 2024 •
edited
Loading

#622
#592
#515

@coderabbitai coderabbitai bot mentioned this issue Nov 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
1 participant
@victimsnino