Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make M3U8Parser available for other uses. #2183

Open
patrickmichalina opened this issue Mar 18, 2019 · 5 comments
Open

Make M3U8Parser available for other uses. #2183

patrickmichalina opened this issue Mar 18, 2019 · 5 comments
Labels
Feature proposal Revisit-at-later-release-cycle Will revisit during release cycle indicated by the Milestone

Comments

@patrickmichalina
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Since Safari for iOS does not emit events about the available quality levels in an HLS video, there is no native way to create a custom quality selection menu to overlay an HLS video. This of course is easy to do with hls.js because it parses the manifest and emits an event with available qualities.

My request here is for this library to export its M3U8Parser so it can be used in Safari to achieve this. The alternative is to use another m3u8 parser which just adds more javascript overhead and has the potential to not parse the same way - causing mismatch between clients.

Describe alternatives you've considered

Something like this library m3u8-file-parser

@stale stale bot added the Stale label May 17, 2019
@stale stale bot closed this as completed Jun 16, 2019
@itsjamie
Copy link
Collaborator

Hello @patrickmichalina, sorry this went stale.

I'll mark this for consideration for the 1.0 API.

I could see us including this and exporting it, but not including it in the API guarantee for semver. Would that be ok for your purposes?

Mostly, it shouldn't be an issue, but the less API that is part of the public guarantee the easier it is to get minor fixes in without having to discuss if it's a breaking change.

@itsjamie itsjamie reopened this Jun 16, 2019
@stale stale bot removed the Stale label Jun 16, 2019
@itsjamie itsjamie added this to the 1.0.0 milestone Jun 16, 2019
@patrickmichalina
Copy link
Contributor Author

That would work! Thank you

@robwalch
Copy link
Collaborator

robwalch commented Sep 1, 2023

This issue might be resolved by adding a named export of M3U8Parser but our last attempt to add named exported to the default library export failed: Related to #5630 and #5729.

@TeodorDre
Copy link

Any updates here? Also, it is a good feature for SmartTV (WebOS / Tizen) Players

@robwalch
Copy link
Collaborator

robwalch commented Dec 1, 2023

Would you like to submit a PR making the parser available for ESM import by adding M3U8Parser to https://github.com/video-dev/hls.js/blob/master/src/exports-named.ts ?

@video-dev video-dev deleted a comment from stale bot Dec 1, 2023
@robwalch robwalch added the Revisit-at-later-release-cycle Will revisit during release cycle indicated by the Milestone label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature proposal Revisit-at-later-release-cycle Will revisit during release cycle indicated by the Milestone
Projects
Development

No branches or pull requests

4 participants