-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some manifest files crash player when using hls.light.min.js
with undefined
(hasAutoSelect) error
#6316
Comments
hls.light.min.js
with undefined hasAutoSelect error
hls.light.min.js
with undefined hasAutoSelect errorhls.light.min.js
with undefined
(hasAutoSelect) error
I'm able to repro this on the vanilla (non-light) version as well |
Confirmed the fix (#6342) works for the non-light version also |
Hi @davidgoli, Thanks for the confirmation. Can you provide an example of this failure with the full version (using 1.5.7)? I'm interested to know how you would end up with a variant listing an audio-group-id that could not be found in |
Great question! I have a video with no audio tracks at all:
I admittedly did not debug super deeply when I hit the bug, I just upgraded to latest hls.js and found it fixed it. |
In that case, the code that was throwing for this bug shouldn't have run at all. |
What version of Hls.js are you using?
v1.5.7 (
hls.light.min.js
from jsdeliver)What browser (including version) are you using?
Firefox/Chrome latest
What OS (including version) are you using?
Mac Sonoma
Test stream
https://github.com/harshbaz/hlsjs-desktop-playback-error
Codesandbox: https://codesandbox.io/p/github/harshbaz/hlsjs-desktop-playback-error/main
Configuration
Additional player setup steps
Sorry about the checklist, but the error only happens when few conditions are met:
hls.light.min.js
is used. (plays fine withhls.min.js
)I have created a separate repository and there's no extra logic in there: https://github.com/harshbaz/hlsjs-desktop-playback-error
Checklist
Steps to reproduce
Expected behaviour
Both the manifest files should play fine. If there is an error, an error event should be thrown and error should be handled gracefully
What actually happened?
The Hls player crashes will no ability to react to the error while trying to play
Console output
Chrome media internals output
No response
The text was updated successfully, but these errors were encountered: