Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setAudioOption skips track selection at index 0 #6774

Closed
5 tasks done
matvp91 opened this issue Oct 15, 2024 · 4 comments · Fixed by #6775
Closed
5 tasks done

setAudioOption skips track selection at index 0 #6774

matvp91 opened this issue Oct 15, 2024 · 4 comments · Fixed by #6775

Comments

@matvp91
Copy link
Contributor

matvp91 commented Oct 15, 2024

What version of Hls.js are you using?

v1.6.0-beta.1

What browser (including version) are you using?

Chrome 129.0.6668.101

What OS (including version) are you using?

macOS

Test stream

No response

Configuration

{
  "debug": true,
  "enableWorker": true,
  "lowLatencyMode": true,
  "backBufferLength": 90
}

Additional player setup steps

No response

Checklist

Steps to reproduce

image

Expected behaviour

When selecting a different groupId in setAudioOption, HLS.js should switch to the right group internally.

What actually happened?

HLS.js does not select the track with index 0.

Console output

N/A

Chrome media internals output

No response

@matvp91 matvp91 added Bug Needs Triage If there is a suspected stream issue, apply this label to triage if it is something we should fix. labels Oct 15, 2024
@robwalch robwalch added this to the 1.5.17 milestone Oct 16, 2024
@robwalch robwalch added Confirmed and removed Needs Triage If there is a suspected stream issue, apply this label to triage if it is something we should fix. labels Oct 16, 2024
@robwalch
Copy link
Collaborator

This issue is in v1.5.16 too. We'll have to cherry-pick the fix in patch/v1.5.x and cut a patch as this should work in the latest stable release as well.

@robwalch
Copy link
Collaborator

Cherry-picked into patch/v1.5.x. If this build (https://github.com/video-dev/hls.js/runs/31691495472) fixes the issue for v1.5.16, we'll tag it as patch v1.5.17.

@matvp91 does selection work correctly for you at this preview URL?
https://patch-v1-5-x.hls-js-4zn.pages.dev/demo/

@matvp91
Copy link
Contributor Author

matvp91 commented Oct 17, 2024

image

All good. 👍

@robwalch
Copy link
Collaborator

Thanks @matvp91! This release is for you: https://github.com/video-dev/hls.js/releases/tag/v1.5.17

Pro-tip: setAudioOption accepts track object references as input (for a fast or direct match):
hls.setAudioOption(hls.allAudioTracks[0])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants