Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: llHLS does not need forcedTimestampOffset #1501

Merged
merged 2 commits into from
Apr 2, 2024
Merged

fix: llHLS does not need forcedTimestampOffset #1501

merged 2 commits into from
Apr 2, 2024

Conversation

adrums86
Copy link
Contributor

@adrums86 adrums86 commented Apr 1, 2024

Description

timestampOffset was being reset on LL-HLS quality changes. We only want to force timestampOffset changes on rendition switches for .ts segments due to the timestamp rollover problem in those containers.

Specific Changes proposed

Check if the current media is fmp4, if it is don't force the timestampOffset reset after a resync of the segment loader.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.27%. Comparing base (ddc9374) to head (0110e24).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1501   +/-   ##
=======================================
  Coverage   86.27%   86.27%           
=======================================
  Files          43       43           
  Lines       10884    10886    +2     
  Branches     2504     2506    +2     
=======================================
+ Hits         9390     9392    +2     
  Misses       1494     1494           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrums86 adrums86 marked this pull request as ready for review April 2, 2024 00:45
@adrums86 adrums86 merged commit f5d1209 into main Apr 2, 2024
15 checks passed
@adrums86 adrums86 deleted the fix-llHLS branch April 2, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants