Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enableFunction not passing playlist to fastQualityChange #1502

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

adrums86
Copy link
Contributor

@adrums86 adrums86 commented Apr 4, 2024

Description

Our rendition mixin enableFunction is used to select a rendition/variant for playback. This function uses the playlist controller fastQualityChange_ to do this switch, however we were not passing the playlist during this call, resulting in inconsistent quality switches due to the next playlist coming from a selectPlaylist() call instead of user selection.

Specific Changes proposed

Pass playlist as a parameter during the fastQualityChange_ /changePlaylistFn call

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.27%. Comparing base (f5d1209) to head (df553ec).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1502   +/-   ##
=======================================
  Coverage   86.27%   86.27%           
=======================================
  Files          43       43           
  Lines       10886    10886           
  Branches     2506     2506           
=======================================
  Hits         9392     9392           
  Misses       1494     1494           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dzianis-dashkevich
Copy link
Contributor

Great finding!

@adrums86 adrums86 merged commit e50ecb1 into main Apr 4, 2024
15 checks passed
@adrums86 adrums86 deleted the fix-enableFunction branch April 4, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants