feat: output segment title from EXTINF (#158)

videojs · Jul 7, 2023 · 4adaa2c · 4adaa2c
1 parent 516ab67
commit 4adaa2c
Show file tree

Hide file tree

Showing 16 changed files with 108 additions and 51 deletions.
diff --git a/README.md b/README.md
@@ -113,6 +113,7 @@ Manifest {
   discontinuityStarts: [number],
   segments: [
     {
+      title: string,
       byterange: {
         length: number,
         offset: number

diff --git a/src/parser.js b/src/parser.js
@@ -221,6 +221,11 @@ export default class Parser extends Stream {
                   message: 'defaulting discontinuity sequence to zero'
                 });
               }
+
+              if (entry.title) {
+                currentUri.title = entry.title;
+              }
+
               if (entry.duration > 0) {
                 currentUri.duration = entry.duration;
               }

diff --git a/test/fixtures/integration/disc-sequence.js b/test/fixtures/integration/disc-sequence.js
@@ -6,23 +6,27 @@ module.exports = {
     {
       duration: 10,
       timeline: 3,
-      uri: '001.ts'
+      uri: '001.ts',
+      title: '0'
     },
     {
       duration: 19,
       timeline: 3,
-      uri: '002.ts'
+      uri: '002.ts',
+      title: '0'
     },
     {
       discontinuity: true,
       duration: 10,
       timeline: 4,
-      uri: '003.ts'
+      uri: '003.ts',
+      title: '0'
     },
     {
       duration: 11,
       timeline: 4,
-      uri: '004.ts'
+      uri: '004.ts',
+      title: '0'
     }
   ],
   targetDuration: 19,

diff --git a/test/fixtures/integration/discontinuity.js b/test/fixtures/integration/discontinuity.js
@@ -6,50 +6,59 @@ module.exports = {
     {
       duration: 10,
       timeline: 0,
-      uri: '001.ts'
+      uri: '001.ts',
+      title: '0'
     },
     {
       duration: 19,
       timeline: 0,
-      uri: '002.ts'
+      uri: '002.ts',
+      title: '0'
     },
     {
       discontinuity: true,
       duration: 10,
       timeline: 1,
-      uri: '003.ts'
+      uri: '003.ts',
+      title: '0'
     },
     {
       duration: 11,
       timeline: 1,
-      uri: '004.ts'
+      uri: '004.ts',
+      title: '0'
     },
     {
       discontinuity: true,
       duration: 10,
       timeline: 2,
-      uri: '005.ts'
+      uri: '005.ts',
+      title: '0'
     },
     {
       duration: 10,
       timeline: 2,
-      uri: '006.ts'
+      uri: '006.ts',
+      title: '0'
     },
     {
       duration: 10,
       timeline: 2,
-      uri: '007.ts'
+      uri: '007.ts',
+      title: '0'
     },
     {
       discontinuity: true,
       duration: 10,
       timeline: 3,
-      uri: '008.ts'
+      uri: '008.ts',
+      title: '0'
     },
     {
       duration: 16,
       timeline: 3,
-      uri: '009.ts'
+      uri: '009.ts',
+      title: '0'
     }
   ],
   targetDuration: 19,

diff --git a/test/fixtures/integration/emptyMediaSequence.js b/test/fixtures/integration/emptyMediaSequence.js
@@ -6,22 +6,26 @@ module.exports = {
     {
       duration: 6.64,
       timeline: 0,
-      uri: '/test/ts-files/tvy7/8a5e2822668b5370f4eb1438b2564fb7ab12ffe1-hi720.ts'
+      uri: '/test/ts-files/tvy7/8a5e2822668b5370f4eb1438b2564fb7ab12ffe1-hi720.ts',
+      title: '{}'
     },
     {
       duration: 6.08,
       timeline: 0,
-      uri: '/test/ts-files/tvy7/56be1cef869a1c0cc8e38864ad1add17d187f051-hi720.ts'
+      uri: '/test/ts-files/tvy7/56be1cef869a1c0cc8e38864ad1add17d187f051-hi720.ts',
+      title: '{}'
     },
     {
       duration: 6.6,
       timeline: 0,
-      uri: '/test/ts-files/tvy7/549c8c77f55f049741a06596e5c1e01dacaa46d0-hi720.ts'
+      uri: '/test/ts-files/tvy7/549c8c77f55f049741a06596e5c1e01dacaa46d0-hi720.ts',
+      title: '{}'
     },
     {
       duration: 5,
       timeline: 0,
-      uri: '/test/ts-files/tvy7/6cfa378684ffeb1c455a64dae6c103290a1f53d4-hi720.ts'
+      uri: '/test/ts-files/tvy7/6cfa378684ffeb1c455a64dae6c103290a1f53d4-hi720.ts',
+      title: '{}'
     }
   ],
   targetDuration: 8,

diff --git a/test/fixtures/integration/extXPlaylistTypeInvalidPlaylist.js b/test/fixtures/integration/extXPlaylistTypeInvalidPlaylist.js
@@ -5,7 +5,8 @@ module.exports = {
     {
       duration: 6.64,
       timeline: 0,
-      uri: '/test/ts-files/tvy7/8a5e2822668b5370f4eb1438b2564fb7ab12ffe1-hi720.ts'
+      uri: '/test/ts-files/tvy7/8a5e2822668b5370f4eb1438b2564fb7ab12ffe1-hi720.ts',
+      title: '{}'
     }
   ],
   targetDuration: 8,

diff --git a/test/fixtures/integration/extinf.js b/test/fixtures/integration/extinf.js
@@ -19,7 +19,8 @@ module.exports = {
       },
       duration: 10,
       timeline: 0,
-      uri: 'hls_450k_video.ts'
+      uri: 'hls_450k_video.ts',
+      title: ';asljasdfii11)))00,'
     },
     {
       byterange: {

diff --git a/test/fixtures/integration/invalidMediaSequence.js b/test/fixtures/integration/invalidMediaSequence.js
@@ -6,22 +6,26 @@ module.exports = {
     {
       duration: 6.64,
       timeline: 0,
-      uri: '/test/ts-files/tvy7/8a5e2822668b5370f4eb1438b2564fb7ab12ffe1-hi720.ts'
+      uri: '/test/ts-files/tvy7/8a5e2822668b5370f4eb1438b2564fb7ab12ffe1-hi720.ts',
+      title: '{}'
     },
     {
       duration: 6.08,
       timeline: 0,
-      uri: '/test/ts-files/tvy7/56be1cef869a1c0cc8e38864ad1add17d187f051-hi720.ts'
+      uri: '/test/ts-files/tvy7/56be1cef869a1c0cc8e38864ad1add17d187f051-hi720.ts',
+      title: '{}'
     },
     {
       duration: 6.6,
       timeline: 0,
-      uri: '/test/ts-files/tvy7/549c8c77f55f049741a06596e5c1e01dacaa46d0-hi720.ts'
+      uri: '/test/ts-files/tvy7/549c8c77f55f049741a06596e5c1e01dacaa46d0-hi720.ts',
+      title: '{}'
     },
     {
       duration: 5,
       timeline: 0,
-      uri: '/test/ts-files/tvy7/6cfa378684ffeb1c455a64dae6c103290a1f53d4-hi720.ts'
+      uri: '/test/ts-files/tvy7/6cfa378684ffeb1c455a64dae6c103290a1f53d4-hi720.ts',
+      title: '{}'
     }
   ],
   targetDuration: 8,

diff --git a/test/fixtures/integration/liveMissingSegmentDuration.js b/test/fixtures/integration/liveMissingSegmentDuration.js
@@ -6,7 +6,8 @@ module.exports = {
     {
       duration: 6.64,
       timeline: 0,
-      uri: '/test/ts-files/tvy7/8a5e2822668b5370f4eb1438b2564fb7ab12ffe1-hi720.ts'
+      uri: '/test/ts-files/tvy7/8a5e2822668b5370f4eb1438b2564fb7ab12ffe1-hi720.ts',
+      title: '{}'
     },
     {
       duration: 8,

diff --git a/test/fixtures/integration/liveStart30sBefore.js b/test/fixtures/integration/liveStart30sBefore.js
@@ -5,47 +5,56 @@ module.exports = {
     {
       duration: 10,
       timeline: 0,
-      uri: '001.ts'
+      uri: '001.ts',
+      title: '0'
     },
     {
       duration: 19,
       timeline: 0,
-      uri: '002.ts'
+      uri: '002.ts',
+      title: '0'
     },
     {
       duration: 10,
       timeline: 0,
-      uri: '003.ts'
+      uri: '003.ts',
+      title: '0'
     },
     {
       duration: 11,
       timeline: 0,
-      uri: '004.ts'
+      uri: '004.ts',
+      title: '0'
     },
     {
       duration: 10,
       timeline: 0,
-      uri: '005.ts'
+      uri: '005.ts',
+      title: '0'
     },
     {
       duration: 10,
       timeline: 0,
-      uri: '006.ts'
+      uri: '006.ts',
+      title: '0'
     },
     {
       duration: 10,
       timeline: 0,
-      uri: '007.ts'
+      uri: '007.ts',
+      title: '0'
     },
     {
       duration: 10,
       timeline: 0,
-      uri: '008.ts'
+      uri: '008.ts',
+      title: '0'
     },
     {
       duration: 16,
       timeline: 0,
-      uri: '009.ts'
+      uri: '009.ts',
+      title: '0'
     }
   ],
   targetDuration: 10,

diff --git a/test/fixtures/integration/mediaSequence.js b/test/fixtures/integration/mediaSequence.js
@@ -6,22 +6,26 @@ module.exports = {
     {
       duration: 6.64,
       timeline: 0,
-      uri: '/test/ts-files/tvy7/8a5e2822668b5370f4eb1438b2564fb7ab12ffe1-hi720.ts'
+      uri: '/test/ts-files/tvy7/8a5e2822668b5370f4eb1438b2564fb7ab12ffe1-hi720.ts',
+      title: '{}'
     },
     {
       duration: 6.08,
       timeline: 0,
-      uri: '/test/ts-files/tvy7/56be1cef869a1c0cc8e38864ad1add17d187f051-hi720.ts'
+      uri: '/test/ts-files/tvy7/56be1cef869a1c0cc8e38864ad1add17d187f051-hi720.ts',
+      title: '{}'
     },
     {
       duration: 6.6,
       timeline: 0,
-      uri: '/test/ts-files/tvy7/549c8c77f55f049741a06596e5c1e01dacaa46d0-hi720.ts'
+      uri: '/test/ts-files/tvy7/549c8c77f55f049741a06596e5c1e01dacaa46d0-hi720.ts',
+      title: '{}'
     },
     {
       duration: 5,
       timeline: 0,
-      uri: '/test/ts-files/tvy7/6cfa378684ffeb1c455a64dae6c103290a1f53d4-hi720.ts'
+      uri: '/test/ts-files/tvy7/6cfa378684ffeb1c455a64dae6c103290a1f53d4-hi720.ts',
+      title: '{}'
     }
   ],
   targetDuration: 8,

diff --git a/test/fixtures/integration/missingMediaSequence.js b/test/fixtures/integration/missingMediaSequence.js
@@ -6,22 +6,26 @@ module.exports = {
     {
       duration: 6.64,
       timeline: 0,
-      uri: '/test/ts-files/tvy7/8a5e2822668b5370f4eb1438b2564fb7ab12ffe1-hi720.ts'
+      uri: '/test/ts-files/tvy7/8a5e2822668b5370f4eb1438b2564fb7ab12ffe1-hi720.ts',
+      title: '{}'
     },
     {
       duration: 6.08,
       timeline: 0,
-      uri: '/test/ts-files/tvy7/56be1cef869a1c0cc8e38864ad1add17d187f051-hi720.ts'
+      uri: '/test/ts-files/tvy7/56be1cef869a1c0cc8e38864ad1add17d187f051-hi720.ts',
+      title: '{}'
     },
     {
       duration: 6.6,
       timeline: 0,
-      uri: '/test/ts-files/tvy7/549c8c77f55f049741a06596e5c1e01dacaa46d0-hi720.ts'
+      uri: '/test/ts-files/tvy7/549c8c77f55f049741a06596e5c1e01dacaa46d0-hi720.ts',
+      title: '{}'
     },
     {
       duration: 5,
       timeline: 0,
-      uri: '/test/ts-files/tvy7/6cfa378684ffeb1c455a64dae6c103290a1f53d4-hi720.ts'
+      uri: '/test/ts-files/tvy7/6cfa378684ffeb1c455a64dae6c103290a1f53d4-hi720.ts',
+      title: '{}'
     }
   ],
   targetDuration: 8,

diff --git a/test/fixtures/integration/missingSegmentDuration.js b/test/fixtures/integration/missingSegmentDuration.js
@@ -6,7 +6,8 @@ module.exports = {
     {
       duration: 6.64,
       timeline: 0,
-      uri: '/test/ts-files/tvy7/8a5e2822668b5370f4eb1438b2564fb7ab12ffe1-hi720.ts'
+      uri: '/test/ts-files/tvy7/8a5e2822668b5370f4eb1438b2564fb7ab12ffe1-hi720.ts',
+      title: '{}'
     },
     {
       duration: 8,

diff --git a/test/fixtures/integration/negativeMediaSequence.js b/test/fixtures/integration/negativeMediaSequence.js
@@ -6,22 +6,26 @@ module.exports = {
     {
       duration: 6.64,
       timeline: 0,
-      uri: '/test/ts-files/tvy7/8a5e2822668b5370f4eb1438b2564fb7ab12ffe1-hi720.ts'
+      uri: '/test/ts-files/tvy7/8a5e2822668b5370f4eb1438b2564fb7ab12ffe1-hi720.ts',
+      title: '{}'
     },
     {
       duration: 6.08,
       timeline: 0,
-      uri: '/test/ts-files/tvy7/56be1cef869a1c0cc8e38864ad1add17d187f051-hi720.ts'
+      uri: '/test/ts-files/tvy7/56be1cef869a1c0cc8e38864ad1add17d187f051-hi720.ts',
+      title: '{}'
     },
     {
       duration: 6.6,
       timeline: 0,
-      uri: '/test/ts-files/tvy7/549c8c77f55f049741a06596e5c1e01dacaa46d0-hi720.ts'
+      uri: '/test/ts-files/tvy7/549c8c77f55f049741a06596e5c1e01dacaa46d0-hi720.ts',
+      title: '{}'
     },
     {
       duration: 5,
       timeline: 0,
-      uri: '/test/ts-files/tvy7/6cfa378684ffeb1c455a64dae6c103290a1f53d4-hi720.ts'
+      uri: '/test/ts-files/tvy7/6cfa378684ffeb1c455a64dae6c103290a1f53d4-hi720.ts',
+      title: '{}'
     }
   ],
   targetDuration: 8,

diff --git a/test/fixtures/integration/playlistMediaSequenceHigher.js b/test/fixtures/integration/playlistMediaSequenceHigher.js
@@ -6,7 +6,8 @@ module.exports = {
     {
       duration: 6.64,
       timeline: 0,
-      uri: '/test/ts-files/tvy7/8a5e2822668b5370f4eb1438b2564fb7ab12ffe1-hi720.ts'
+      uri: '/test/ts-files/tvy7/8a5e2822668b5370f4eb1438b2564fb7ab12ffe1-hi720.ts',
+      title: '{}'
     }
   ],
   targetDuration: 8,