Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.5.1 with Typescript crash (vhs-utils) #119

Closed
Tawagot0 opened this issue Jan 12, 2021 · 6 comments
Closed

4.5.1 with Typescript crash (vhs-utils) #119

Tawagot0 opened this issue Jan 12, 2021 · 6 comments

Comments

@Tawagot0
Copy link

Tawagot0 commented Jan 12, 2021

Hello, my project crash with m3u8-parser (4.5.1) and MR #118 @brandonocasey

Environment: Linux
Tested on Windows and working but not on Linux, and working with downgrade to 4.5.0 with Linux.

/root/project/node_modules/@videojs/vhs-utils/es/stream.js:121
export { Stream as default };
^^^^^^

SyntaxError: Unexpected token 'export'
    at wrapSafe (internal/modules/cjs/loader.js:1116:16)
    at Module._compile (internal/modules/cjs/loader.js:1164:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1220:10)
    at Module.load (internal/modules/cjs/loader.js:1049:32)
    at Function.Module._load (internal/modules/cjs/loader.js:937:14)
    at Module.require (internal/modules/cjs/loader.js:1089:19)
    at require (internal/modules/cjs/helpers.js:73:18)
    at Object.<anonymous> (/root/project/node_modules/m3u8-parser/dist/m3u8-parser.cjs.js:9:30)
    at Module._compile (internal/modules/cjs/loader.js:1200:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1220:10)
    at Module.load (internal/modules/cjs/loader.js:1049:32)
    at Function.Module._load (internal/modules/cjs/loader.js:937:14)
    at Module.require (internal/modules/cjs/loader.js:1089:19)
    at require (internal/modules/cjs/helpers.js:73:18)
    at Object.<anonymous> (/root/project/src/m3u8.ts:3:20)
    at Module._compile (internal/modules/cjs/loader.js:1200:30)
@clementallen
Copy link

I get the same, this can be replicated in Runkit by just importing the module.

4.5.1 broken: https://runkit.com/embed/hj5aa8uahdju

4.5.0 working: https://runkit.com/embed/vja7jq5zw7n3

@gkatsev
Copy link
Member

gkatsev commented Jan 12, 2021

Thanks for opening the issue, we'll take a look.

@gkatsev
Copy link
Member

gkatsev commented Jan 12, 2021

We fixed in in #120. Next patch release should be out soon.

@brandonocasey
Copy link
Contributor

Should be out as a part of 4.5.2

@clementallen
Copy link

Thanks for the quick response @gkatsev @brandonocasey - tested the new version and it's working for me 👍

@gkatsev
Copy link
Member

gkatsev commented Jan 12, 2021

Thanks for verifying @clementallen!

@gkatsev gkatsev closed this as completed Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants