chore: switch to rollup-plugin-data-files #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
commented
Jan 20, 2021
| @@ -1,6 +1,6 @@ | |||
| import QUnit from 'qunit'; | |||
| import testDataExpected from './dist/test-expected.js'; | |||
| import testDataManifests from './dist/test-manifests.js'; | |||
| import testDataExpected from 'data-files!expecteds'; | |||
There was a problem hiding this comment.
Use the plugin
brandonocasey
commented
Jan 20, 2021
| @@ -1,4 +1,4 @@ | |||
| { | |||
| module.exports = { | |||
There was a problem hiding this comment.
Module.exports these objects as we should have been all along.
gkatsev
approved these changes
Jan 21, 2021
brandonocasey
force-pushed
the
rollup-plugin-data-files
branch
from
0724399 to
f84e941
Compare
brandonocasey
added a commit
that referenced
this pull request
Jan 21, 2021
miadabdi
pushed a commit
to miadabdi/m3u8-parser
that referenced
this pull request
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to rollup-plugin-data-files
This allows us to:
mux.js,mpd-paser,@videojs/http-streaming, and anywhere else we need it.