Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: non standard tag match #156

Merged
merged 4 commits into from
Sep 27, 2022
Merged

fix: non standard tag match #156

merged 4 commits into from
Sep 27, 2022

Conversation

Essk
Copy link
Contributor

@Essk Essk commented Sep 22, 2022

Fixes #22

Brings in changes from PR #50 to a present-day base.

This might be considered a breaking change as the library will no longer tolerate missing : tag delimiter.

Ofer Shem Tov and others added 4 commits August 6, 2018 13:47
fixed tests with minimal tag to test tags ended with ':'
- note that missing `:` separator is no longer valid
@Essk Essk marked this pull request as ready for review September 23, 2022 13:42
Copy link
Contributor

@brandonocasey brandonocasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's probably safest to make this a breaking change.

test/parser.test.js Show resolved Hide resolved
@Essk Essk merged commit 8d56f30 into main Sep 27, 2022
@Essk Essk deleted the 22-fix-non-standard-tag-match branch September 27, 2022 16:05
@Essk Essk mentioned this pull request Sep 27, 2022
ryancase added a commit to TransmitLive/m3u8-parser that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception on #EXT-X-MEDIA-TIME tag
2 participants