fix: merge dateRange tags with same IDs and no conflicting attributes #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harisha-swaminathan
changed the title
| @@ -685,21 +685,28 @@ export default class Parser extends Stream { | |||
| } | |||
| if (dateRange.duration && dateRange.endDate) { | |||
| const startDate = dateRange.startDate; | |||
| const newDateInSeconds = startDate.setSeconds(startDate.getSeconds() + dateRange.duration); | |||
| const newDateInSeconds = startDate.getTime() + (dateRange.duration * 1000); | |||
There was a problem hiding this comment.
Don't know why this was startDate.setSeconds(startDate.getSeconds() + dateRange.duration);
I think the setSeconds was a typo and was meant to be `getSeconds()'.
For more context on this block of code, the spec mentions
If a Date Range contains both a DURATION attribute and an END-DATE attribute, the value of the END-DATE attribute MUST be equal to the value of the START-DATE attribute plus the value of the DURATION attribute.
https://datatracker.ietf.org/doc/html/draft-pantos-http-live-streaming-23#section-4.3.2.7
adrums86
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the PR that added the dateRange feature, the specification
If a Playlist contains two EXT-X-DATERANGE tags with the same ID attribute value, then any AttributeName that appears in both tags MUST have the same AttributeValue.was misinterpreted as
EXT-X-DATERANGE tags with the same ID in a playlist must have the same attributes and same attribute values.This PR