Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXT-X-BYTERANGE parsing incorrect when offset not present #78

Closed
mjneil opened this issue Jan 22, 2019 · 7 comments
Closed

EXT-X-BYTERANGE parsing incorrect when offset not present #78

mjneil opened this issue Jan 22, 2019 · 7 comments

Comments

@mjneil
Copy link
Contributor

mjneil commented Jan 22, 2019

The offset portion of the EXT-X-BYTERANGE tag is optional, and should be calculated using the previous segment's offset and bytelength, however the parser currently just assumes a missing offset should default to 0.

https://tools.ietf.org/html/draft-pantos-http-live-streaming-23#section-4.3.2.2

If o is not present, the sub-range begins at the next byte following the sub-range of the previous Media Segment.

@mrlika
Copy link

mrlika commented May 14, 2019

Hi,
Is it going to be fixed? When will be the next release?

@gesinger
Copy link
Contributor

gesinger commented Oct 3, 2019

A fix is in progress: #98

@jaredstehler
Copy link

PR #98 fixes this issue for me; can we resolve this and publish a new release?

@AwokeKnowing
Copy link

Is this released?

@gesinger
Copy link
Contributor

Sorry for the delay, published as v4.4.3

@AwokeKnowing
Copy link

@gesinger Thanks! sorry for my ignorance, we use videojs with eme plugin. Does this m3u8 parser get bundled into videojs?

@gesinger
Copy link
Contributor

We'll have to get the new version into https://github.com/videojs/http-streaming, but we should be doing that soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants