feat: remove flash tech (#3956)

Remove Flash Tech from core. Use videojs-flash if flash is needed.
Also, update DOM method names.

BREAKING CHANGE: remove flash tech from core.

package.json

@@ -41,7 +41,6 @@
     "tsml": "1.0.1",
     "videojs-font": "2.0.0",
     "videojs-ie8": "1.1.2",
-    "videojs-swf": "5.1.0",
     "videojs-vtt.js": "0.12.1",
     "xhr": "2.2.2"
   },

src/js/component.js

@@ -5,6 +5,7 @@
  */
 import window from 'global/window';
 import * as Dom from './utils/dom.js';
+import * as DomData from './utils/dom-data';
 import * as Fn from './utils/fn.js';
 import * as Guid from './utils/guid.js';
 import * as Events from './utils/events.js';
@@ -141,7 +142,7 @@ class Component {
       this.el_.parentNode.removeChild(this.el_);
     }
 
-    Dom.removeElData(this.el_);
+    DomData.removeData(this.el_);
     this.el_ = null;
   }
 
@@ -816,7 +817,7 @@ class Component {
    *         - False if the `Component` does not have the class`
    */
   hasClass(classToCheck) {
-    return Dom.hasElClass(this.el_, classToCheck);
+    return Dom.hasClass(this.el_, classToCheck);
   }
 
   /**
@@ -826,7 +827,7 @@ class Component {
    *        CSS class name to add
    */
   addClass(classToAdd) {
-    Dom.addElClass(this.el_, classToAdd);
+    Dom.addClass(this.el_, classToAdd);
   }
 
   /**
@@ -836,7 +837,7 @@ class Component {
    *        CSS class name to remove
    */
   removeClass(classToRemove) {
-    Dom.removeElClass(this.el_, classToRemove);
+    Dom.removeClass(this.el_, classToRemove);
   }
 
   /**
@@ -851,7 +852,7 @@ class Component {
    *         An {@link Dom~predicate} function or a boolean
    */
   toggleClass(classToToggle, predicate) {
-    Dom.toggleElClass(this.el_, classToToggle, predicate);
+    Dom.toggleClass(this.el_, classToToggle, predicate);
   }
 
   /**

src/js/control-bar/mute-toggle.js

@@ -88,9 +88,9 @@ class MuteToggle extends Button {
 
     // TODO improve muted icon classes
     for (let i = 0; i < 4; i++) {
-      Dom.removeElClass(this.el_, `vjs-vol-${i}`);
+      Dom.removeClass(this.el_, `vjs-vol-${i}`);
     }
-    Dom.addElClass(this.el_, `vjs-vol-${level}`);
+    Dom.addClass(this.el_, `vjs-vol-${level}`);
   }
 
 }

src/js/menu/menu-button.js

@@ -83,7 +83,7 @@ class MenuButton extends ClickableComponent {
       });
 
       menu.children_.unshift(title);
-      Dom.insertElFirst(title, menu.contentEl());
+      Dom.prependTo(title, menu.contentEl());
     }
 
     this.items = this.createItems();

src/js/player.js

@@ -31,7 +31,6 @@ import {ALL as TRACK_TYPES} from './tracks/track-types';
 // are always included in the video.js package. Importing the modules will
 // execute them and they will register themselves with video.js.
 import './tech/loader.js';
-import './tech/flash.js';
 import './poster-image.js';
 import './tracks/text-track-display.js';
 import './loading-spinner.js';
@@ -281,7 +280,7 @@ class Player extends Component {
         let element = tag;
 
         while (element && element.nodeType === 1) {
-          if (Dom.getElAttributes(element).hasOwnProperty('lang')) {
+          if (Dom.getAttributes(element).hasOwnProperty('lang')) {
             options.language = element.getAttribute('lang');
             break;
           }
@@ -307,7 +306,7 @@ class Player extends Component {
     this.tag = tag;
 
     // Store the tag attributes used to restore html5 element
-    this.tagAttributes = tag && Dom.getElAttributes(tag);
+    this.tagAttributes = tag && Dom.getAttributes(tag);
 
     // Update current language
     this.language(this.options_.language);
@@ -487,7 +486,7 @@ class Player extends Component {
 
     // Copy over all the attributes from the tag, including ID and class
     // ID will now reference player box, not the video tag
-    const attrs = Dom.getElAttributes(tag);
+    const attrs = Dom.getAttributes(tag);
 
     Object.getOwnPropertyNames(attrs).forEach(function(attr) {
       // workaround so we don't totally break IE7
@@ -534,7 +533,7 @@ class Player extends Component {
     for (let i = 0; i < links.length; i++) {
       const linkEl = links.item(i);
 
-      Dom.addElClass(linkEl, 'vjs-hidden');
+      Dom.addClass(linkEl, 'vjs-hidden');
       linkEl.setAttribute('hidden', 'hidden');
     }
 
@@ -552,7 +551,7 @@ class Player extends Component {
     // will work properly for other components
     //
     // Breaks iPhone, fixed in HTML5 setup.
-    Dom.insertElFirst(tag, el);
+    Dom.prependTo(tag, el);
     this.children_.unshift(tag);
 
     this.el_ = el;
@@ -893,7 +892,7 @@ class Player extends Component {
     // Add the tech element in the DOM if it was not already there
     // Make sure to not insert the original video element if using Html5
     if (this.tech_.el().parentNode !== this.el() && (techName !== 'Html5' || !this.tag)) {
-      Dom.insertElFirst(this.tech_.el(), this.el());
+      Dom.prependTo(this.tech_.el(), this.el());
     }
 
     // Get rid of the original video tag reference after the first tech is loaded
@@ -1999,7 +1998,7 @@ class Player extends Component {
     document.documentElement.style.overflow = 'hidden';
 
     // Apply fullscreen styles
-    Dom.addElClass(document.body, 'vjs-full-window');
+    Dom.addClass(document.body, 'vjs-full-window');
 
     /**
      * @event Player#enterFullWindow
@@ -2038,7 +2037,7 @@ class Player extends Component {
     document.documentElement.style.overflow = this.docOrigOverflow;
 
     // Remove fullscreen styles
-    Dom.removeElClass(document.body, 'vjs-full-window');
+    Dom.removeClass(document.body, 'vjs-full-window');
 
     // Resize the box, controller, and poster to original sizes
     // this.positionAll();
@@ -3042,10 +3041,10 @@ class Player extends Component {
       tracks: []
     };
 
-    const tagOptions = Dom.getElAttributes(tag);
+    const tagOptions = Dom.getAttributes(tag);
     const dataSetup = tagOptions['data-setup'];
 
-    if (Dom.hasElClass(tag, 'vjs-fluid')) {
+    if (Dom.hasClass(tag, 'vjs-fluid')) {
       tagOptions.fluid = true;
     }
 
@@ -3073,9 +3072,9 @@ class Player extends Component {
         const childName = child.nodeName.toLowerCase();
 
         if (childName === 'source') {
-          baseOptions.sources.push(Dom.getElAttributes(child));
+          baseOptions.sources.push(Dom.getAttributes(child));
         } else if (childName === 'track') {
-          baseOptions.tracks.push(Dom.getElAttributes(child));
+          baseOptions.tracks.push(Dom.getAttributes(child));
         }
       }
     }
@@ -3187,8 +3186,7 @@ const navigator = window.navigator;
  */
 Player.prototype.options_ = {
   // Default order of fallback technology
-  techOrder: ['html5', 'flash'],
-  // techOrder: ['flash','html5'],
+  techOrder: ['html5'],
 
   html5: {},
   flash: {},