Use default aspect ratio for fluid players if width unknown #3614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2848,6 +2850,10 @@ class Player extends Component { | |||
| const tagOptions = Dom.getElAttributes(tag); | |||
| const dataSetup = tagOptions['data-setup']; | |||
|
|
|||
| if (Dom.hasElClass(tag, 'vjs-fluid')) { | |||
There was a problem hiding this comment.
should we add a test that verifies that if vjs-fluid class is available then player.fluid() returns true?
There was a problem hiding this comment.
Yes that makes sense, added.
|
Sounds like a great idea. |
|
Trying out the new Projects and reviewing for this PR. |
misteroneill
approved these changes
Sep 15, 2016
gkatsev
added
the
minor
gkatsev
approved these changes
Oct 3, 2016
There was a problem hiding this comment.
LGTM.
@mister-ben I think this could probably needs a rebase against master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a player is fluid and does not have a width set, and preload is set to none, the height of the player is zero. This includes where preload is forced to none by mobile Chrome as in #3606.
Specific Changes proposed
.vjs-fluidclass when initialised,fluidis set totrue, so adding the class behaves the same as{fluid: true}in the setup options.fluid(bool)setter callsplayer.updateStyleEl_(). Otherwise it won't be triggered increateEl()if an aspect ratio is not also set.videoWidth()inupdateStyleEl_()-videoWidth()returns0if the width is unknown. This allows the default16:9to kick in rather than using0:0.Requirements Checklist