Update ru.json #3654

Globulopolis · 2016-09-29T12:52:06Z

Update translation.

gkatsev · 2016-09-29T15:24:07Z

lang/ru.json

-  "The media could not be loaded, either because the server or network failed or because the format is not supported.": "Невозможно загрузить видео из-за сетевого или серверного сбоя либо формат не поддерживается.",
-  "The media playback was aborted due to a corruption problem or because the media used features your browser did not support.": "Воспроизведение видео было приостановлено из-за повреждения либо в связи с тем, что видео использует функции, неподдерживаемые вашим браузером.",
-  "No compatible source was found for this media.": "Совместимые источники для этого видео отсутствуют."
+ "Play": "Воспроизвести",


Can the indentation be fixed here so the diff only shows the new items that were added?

gkatsev · 2016-09-29T16:02:14Z

Awesome thanks. This LGTM.
Though, one question, while we have you here, would you be able to help out with the rest of the missing russian translations? If not, that's fine too.

Globulopolis · 2016-09-29T16:12:27Z

@gkatsev yes, I can help. I just need to know where the untranslated string used in videojs, like modal dialog. Demo would be awesome.

gkatsev · 2016-09-29T16:16:27Z

Sure, I can help. Currently busy at the moment but I'll get back to you in a bit.

gkatsev

Added some comments about the missing items.
The only one that wasn't easily comment-able is , selected which is also related to captions.
If you were to enable captions, the item that is selected should show that text when you hover over it.

@Globulopolis if those makes sense, would love it if you can update this PR with those.
Thanks!

gkatsev · 2016-10-03T17:34:34Z

docs/translations-needed.md

-|                         | Descriptions                                                                        |
-|                         | descriptions off                                                                    |
-|                         | Audio Track                                                                         |
+| ru.json (missing 6 )    | Close Modal Dialog                                                                  |


"Close Modal Dialog" is shows up as text for the close button on the modal dialog.
You can see this by opening a modal dialog and hovering over the close button:

player.createModal('foo');

gkatsev · 2016-10-03T17:36:14Z

docs/translations-needed.md

-|                         | Descriptions                                                                        |
-|                         | descriptions off                                                                    |
-|                         | Audio Track                                                                         |
+| ru.json (missing 6 )    | Close Modal Dialog                                                                  |
 |                         | The media is encrypted and we do not have the keys to decrypt it.                   |


You can see an example of this by running the following snippet:

player.error({code: 5});

It'll open an error dialog with this text in it.
To close the dialog, you call error() with null:

player.error(null); ```.

gkatsev · 2016-10-03T17:39:22Z

docs/translations-needed.md

-|                         | Close                                                                               |
-|                         | Modal Window                                                                        |
-|                         | This is a modal window                                                              |
-|                         | This modal can be closed by pressing the Escape key or activating the close button. |
 |                         | , opens captions settings dialog                                                    |


This shows up as title text when you hover to the "caption settings" menu item. To see this, you'd want to enable emulated text tracks in videojs and add captions:

var player = videojs('vid', { html5: { nativeTextTracks: false } });

Then after playing, if you open the captions menu and hover over the settings item, you can see this text.

gkatsev · 2016-10-03T17:40:01Z

docs/translations-needed.md

-|                         | Close                                                                               |
-|                         | Modal Window                                                                        |
-|                         | This is a modal window                                                              |
-|                         | This modal can be closed by pressing the Escape key or activating the close button. |
 |                         | , opens captions settings dialog                                                    |
 |                         | , opens subtitles settings dialog                                                   |


Same as the caption settings dialog, though, I'm not sure we're currently showing it in any case right now but it would be equivalent to the captions setting dialog when we would do it.

gkatsev · 2016-10-03T17:40:15Z

docs/translations-needed.md

-|                         | Close                                                                               |
-|                         | Modal Window                                                                        |
-|                         | This is a modal window                                                              |
-|                         | This modal can be closed by pressing the Escape key or activating the close button. |
 |                         | , opens captions settings dialog                                                    |
 |                         | , opens subtitles settings dialog                                                   |
 |                         | , opens descriptions settings dialog                                                |


Same as the caption settings dialog, though, I'm not sure we're currently showing it in any case right now but it would be equivalent to the captions setting dialog when we would do it.

gkatsev

Awesome, thanks for the updates!
One small issue.

gkatsev · 2016-10-07T18:31:05Z

lang/ru.json

+  "Play Video": "Воспроизвести видео",
+  "Close": "Закрыть",
+  "Modal Window": "Модальное окно",
+  "This is a modal window.": "Это модальное окно.",


I think this shouldn't have a period at the end.

Yes, see #3654 (comment)

Globulopolis · 2016-10-07T18:33:39Z

@gkatsev all string are translated now. But I found one error.
String https://github.com/videojs/video.js/blob/master/lang/en.json#L34 w/o dot at the end of string, but in https://github.com/videojs/video.js/blob/master/src/js/modal-dialog.js#L135 with a dot at the end.

gkatsev · 2016-10-07T18:35:09Z

@Globulopolis oh, interesting. I didn't realize that. It seems like other translations already assume it's the phrase without the dot, so, might be just easier to change the modial-dialog to assume it's without a dot :)

gkatsev · 2016-10-07T18:35:51Z

What do you think?

Globulopolis · 2016-10-07T18:39:43Z

Yes, update modal-dialog.js much easier.

gkatsev · 2016-10-07T18:53:26Z

@Globulopolis could you update it as well? Thanks!

gkatsev

Thanks @Globulopolis!

gkatsev · 2016-10-07T19:41:24Z

Would you be able to split uk.json into a separate PR?

Globulopolis · 2016-10-07T19:52:33Z

@gkatsev I don't know how :(

gkatsev · 2016-10-07T21:45:01Z

heh, I was going to do a more complicated set of instructions but I think this will work more easily:

You could try something like the following:

$ git checkout -b update-uk.json # create a new branch for uk update
$ git push -u origin update-uk.json # push the branch up, can then be made into a PR
$ git checkout master # go back to master branch
$ git reset --hard HEAD~1 # get rid of the top commit in the branch
$ git push -f origin master # override what's currently on github and in this PR

gkatsev · 2016-11-03T20:06:03Z

Fixed via d11fd50

Update ru.json

2d06e89

gkatsev requested changes Sep 29, 2016

View reviewed changes

Fix indentation

0904cc1

gkatsev approved these changes Sep 29, 2016

View reviewed changes

gkatsev requested changes Oct 3, 2016

View reviewed changes

Globulopolis added 2 commits October 7, 2016 21:16

Update translations

73c3d2e

Update translations

3ac6864

gkatsev requested changes Oct 7, 2016

View reviewed changes

Update translations

b55f520

gkatsev approved these changes Oct 7, 2016

View reviewed changes

misteroneill added the i18n Relation to localisation and translation. label Oct 17, 2016

gkatsev added a commit that referenced this pull request Nov 3, 2016

feat(lang): update ru.json (#3654)

d11fd50

gkatsev closed this Nov 3, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update ru.json #3654

Update ru.json #3654

Globulopolis commented Sep 29, 2016

gkatsev Sep 29, 2016

gkatsev commented Sep 29, 2016

Globulopolis commented Sep 29, 2016

gkatsev commented Sep 29, 2016

gkatsev left a comment

gkatsev Oct 3, 2016

gkatsev Oct 3, 2016

gkatsev Oct 3, 2016

gkatsev Oct 3, 2016

gkatsev Oct 3, 2016

gkatsev left a comment

gkatsev Oct 7, 2016

Globulopolis Oct 7, 2016

Globulopolis commented Oct 7, 2016

gkatsev commented Oct 7, 2016

gkatsev commented Oct 7, 2016

Globulopolis commented Oct 7, 2016

gkatsev commented Oct 7, 2016

gkatsev left a comment

gkatsev commented Oct 7, 2016

Globulopolis commented Oct 7, 2016

gkatsev commented Oct 7, 2016

gkatsev commented Nov 3, 2016

Update ru.json #3654

Update ru.json #3654

Conversation

Globulopolis commented Sep 29, 2016

Choose a reason for hiding this comment

gkatsev commented Sep 29, 2016

Globulopolis commented Sep 29, 2016

gkatsev commented Sep 29, 2016

gkatsev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gkatsev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Globulopolis commented Oct 7, 2016

gkatsev commented Oct 7, 2016

gkatsev commented Oct 7, 2016

Globulopolis commented Oct 7, 2016

gkatsev commented Oct 7, 2016

gkatsev left a comment

Choose a reason for hiding this comment

gkatsev commented Oct 7, 2016

Globulopolis commented Oct 7, 2016

gkatsev commented Oct 7, 2016

gkatsev commented Nov 3, 2016