Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: wrap menu item text in a span #4026

Merged
merged 1 commit into from
Feb 3, 2017
Merged

feat: wrap menu item text in a span #4026

merged 1 commit into from
Feb 3, 2017

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Feb 2, 2017

Fix #4017

@gkatsev gkatsev added the a11y This item might affect the accessibility of the player label Feb 2, 2017
OwenEdwards
OwenEdwards approved these changes Feb 3, 2017
View reviewed changes
Copy link
Member

@OwenEdwards OwenEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gkatsev gkatsev merged commit 5748c36 into master Feb 3, 2017
@gkatsev gkatsev deleted the wrap-menu-items branch February 3, 2017 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OwenEdwards OwenEdwards OwenEdwards approved these changes

Assignees
No one assigned
Labels
a11y This item might affect the accessibility of the player
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkatsev @OwenEdwards