fix: dom.getBoundingClientRect check that el is defined #4139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes sense to have but why does the usage end up being called without an el? |
misteroneill
approved these changes
Feb 28, 2017
There was a problem hiding this comment.
Good with this, but I would echo @gkatsev's question. There's also a problem to fix elsewhere it seems. Probably something not getting cleaned up properly.
|
Should be rebased against master, should make tests run better. |
gkatsev
force-pushed
the
fix/check-for-el
branch
from
41942ec
to
ca6b7ec
Compare
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Verify that
elis defined so that we don't throw if we get to this function with an undefinedelRequirements Checklist