Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a version class to the player #4320

Merged
merged 1 commit into from
May 11, 2017
Merged

Conversation

mister-ben
Copy link
Contributor

Description

Add a version class to the player to simplify CSS for plugins supporting multiple versions. For example to add an icon to a button in v5 you'd target .my-button:before, in v6 .my-button .vjs-icon-placeholder:before.

Specific Changes proposed

Adds a class e.g. vjs-v6 to the player element.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
  • Reviewed by Two Core Contributors

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Did we want to make one against 5.x as well? It won't be as useful but maybe still.

@gkatsev gkatsev merged commit ae423df into videojs:master May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants