fix: only disable user-selection on sliders #4354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlap
reviewed
May 12, 2017
| @@ -18,6 +18,8 @@ | |||
| .vjs-modal-dialog .vjs-modal-dialog-content { | |||
| @extend %fill-parent; | |||
|
|
|||
| @include user-select(auto); | |||
There was a problem hiding this comment.
Why wasn't this user selectable to being with?
There was a problem hiding this comment.
We're disabling user-selection on the player div so that it doesn't get highlighted if you're dragging the progress bar. For whatever reason, even though, it's not supposed to be inherited, it applies on this element.
There was a problem hiding this comment.
mdn says it "applies to subelements", though it's not inherited. Is this something we need to worry about more broadly?
There was a problem hiding this comment.
A thought: what about if we just disabled user selection on the progress bar if that's what we're trying to guard against?
gkatsev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.