Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add package-lock.json file. #4641

Merged
merged 1 commit into from
Oct 19, 2017
Merged

Conversation

misteroneill
Copy link
Member

Adds the package-lock.json file for npm 5.

Requirements Checklist

  • Feature implemented / Bug fixed
  • Reviewed by Two Core Contributors

@thijstriemstra
Copy link
Contributor

What's the purpose of this file?

@gkatsev
Copy link
Member

gkatsev commented Oct 13, 2017

It's to make the development more reproducible once we move over to use npm5: https://docs.npmjs.com/files/package-locks

@thijstriemstra
Copy link
Contributor

Thanks for the info @gkatsev. Looks very complex, SVN like (e.g. .svn dirs), too bad.

@gkatsev
Copy link
Member

gkatsev commented Oct 13, 2017

@thijstriemstra yw, thanks for looking at PR!
Hopefully, we won't really need to look at this file ever really. We just wanted to get this added separately/explicitly.

@thijstriemstra
Copy link
Contributor

pro-tip: don't take a look at the diff. github is right, it's too big ;)

@gkatsev gkatsev merged commit ec5b603 into videojs:master Oct 19, 2017
@misteroneill misteroneill deleted the pkg-lock branch October 23, 2017 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants