fix: Make sure time displays use correctly-formatted time. #4643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
commented
Oct 3, 2017
| @@ -66,11 +66,26 @@ class TimeDisplay extends Component { | |||
| if (this.textNode_) { | |||
| this.contentEl_.removeChild(this.textNode_); | |||
| } | |||
| this.textNode_ = document.createTextNode(` -${this.formattedTime_ || '0:00'}`); | |||
| this.textNode_ = document.createTextNode(this.formattedTime_ || '0:00'); | |||
There was a problem hiding this comment.
This was the relevant mistake. Not all sub-classes wanted to display negative formatted times.
brandonocasey
approved these changes
Oct 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent refactoring of time displays is great, but it seems there was a bug where it would always prepend times with
-even when we want a positive number (i.e. everywhere except remaining time display)!Requirements Checklist