Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hide horizontal volume panel while the slider is not active and mute toggle button is on focus #4866

Conversation

mrdtron
Copy link
Contributor

@mrdtron mrdtron commented Jan 9, 2018

Description

Show horizontal volume panel only when the volume slider is active or volume button is hovered but not when focused. This addresses #4431

Requirements Checklist

  • Feature implemented / Bug fixed
  • Reviewed by Two Core Contributors

@gkatsev
Copy link
Member

gkatsev commented Jan 17, 2018

Thanks for the PR and your patience. Code-wide, this looks good. Though, I'd like to take it for a spin before merging.

@gkatsev
Copy link
Member

gkatsev commented Jan 23, 2018

Just took a look, this is pretty great. Thanks!
One thing that I noticed is that if you tab to the mute button the volume slider doesn't show, though, not sure if that's a big deal or not. Any thoughts @OwenEdwards?

@mrdtron
Copy link
Contributor Author

mrdtron commented Jan 24, 2018

@gkatsev Thanks for reviewing this! I'd personally think that slider should appear only when hovering on the mute toggle button or tabbing into it from the keyboard — a good example of the behaviour is the Youtube player — but I'm open to suggestions.

One issue I noticed just now is that once you mute/unmute volume through keyboard volume slider flickers. Fixing that now.

@gkatsev
Copy link
Member

gkatsev commented Jan 24, 2018

Yeah, I guess it's fine not to open the volume slider via the keyboard when tabbing into the mute toggle, looks fine in youtube.

@gkatsev
Copy link
Member

gkatsev commented Jan 24, 2018

And I confirmed no volume slider flicker when toggling mute.

@gkatsev gkatsev added patch This PR can be added to a patch release. needs: LGTM Needs one or more additional approvals labels Jan 24, 2018
Copy link
Contributor

@brandonocasey brandonocasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! I think I have seen this but didn't really notice that it was an issue.

@gkatsev gkatsev added confirmed and removed needs: LGTM Needs one or more additional approvals labels Jan 24, 2018
@gkatsev gkatsev merged commit e628ccd into videojs:master Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed patch This PR can be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants