Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(player): Make 'searchForTrackSelect_' private & use 'el' as parameter in function 'getIsFocusable' #8697

Merged

Conversation

CarlosVillasenor
Copy link
Contributor

Description

Minor update related to the 'spatial navigation' feature to make 'searchForTrackSelect_' private & use 'el' as parameter in function 'getIsFocusable', since in some cases there can be an issue only using 'this.el_' when the function is called.w

Specific Changes proposed

Please list the specific changes involved in this pull request.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.00%. Comparing base (21b4a52) to head (25b68fe).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8697   +/-   ##
=======================================
  Coverage   83.00%   83.00%           
=======================================
  Files         120      120           
  Lines        7995     7996    +1     
  Branches     1925     1926    +1     
=======================================
+ Hits         6636     6637    +1     
  Misses       1359     1359           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants