Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spatial-navigation): keep navigation going when player has an error #8805

Merged
merged 5 commits into from
Jul 22, 2024

Conversation

CarlosVillasenor
Copy link
Contributor

Description

The bug:
Focus is lost when playback error is displayed.

This small PR will update the spatial-navigation logic so when the error modal is shown the spatial-navigation will try to focus the components present in the error modal, in most cases this will be the vjs close button.

Specific Changes proposed

Keep navigation working when player shows the error modal by focusing a component in that modal.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.78%. Comparing base (e78bcc7) to head (e211ac3).
Report is 4 commits behind head on main.

Files Patch % Lines
src/js/spatial-navigation.js 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8805      +/-   ##
==========================================
+ Coverage   83.07%   83.78%   +0.71%     
==========================================
  Files         120      120              
  Lines        8022     8080      +58     
  Branches     1925     1939      +14     
==========================================
+ Hits         6664     6770     +106     
+ Misses       1358     1310      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CarlosVillasenor CarlosVillasenor marked this pull request as ready for review July 22, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants