Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The video player does not currently support global hotkeys. Hotkeys only work when we have focus on the player. This PR is to introduce global hotkey support.
With this change, for example, if you land on the page with a video player, and does not have focus on any specific fields like form fields or the video player, you can perform a hotkey event like space bar key press which will play/pause video.
Specific Changes proposed
Global hotkeys are not turned on by default. To turn on, need to set
userActions.globalHotkeys
option totrue
. As below:Requirements Checklist
npm run docs:api
to error