chore: lint to code to vjs 7 standards #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
force-pushed
the
chore/vjsstandard-7
branch
from
87569aa
to
ebf51b5
Compare
|
It looks like this needs an update to |
misteroneill
approved these changes
Sep 7, 2018
misteroneill
approved these changes
Sep 7, 2018
incompl
approved these changes
Sep 10, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the eslint configuration in favor of using
videojs-standardwhich all of our other projects use. This pr is waiting for: videojs/standard#36 to be merged so that we can turn the jsdoc rules off, even though they are just warnings and won't cause the build to fail.