move time only changes time after clicking stop advancing time [BUG]

[dharkus5000]

Describe the bug
today when i got in game simple calendar opened automatically as usual, i later pressed esc and accidentally closed it and reopened it from the settings, from then on the time would only change after clicking move time (forwards or backwards) after clicking stop advancing time button, at which point the amounts of time i'd added to the time updated properly, incl if i'd clicked a button multiple times while the time wasn't changing

Foundry Information

• Foundry Version: 11.315
• Game System: PF2e 5.13.3
• Simple Calendar Version: 2.4.3
• Simple Calendar Configuration: using in compact mode, have changed names of months in golarion calendar to reflect a tian-xia campaign

Browser (please complete the following information):

• FF 122.0 (update is available...)

[rapus95]

I also get this issue for dnd5e with the default calendar. Simple Calendar only updates its visuals when the real time clock ticks. So once per second and only if the real time progression is enabled. As soon as you stop the real time progression, it won't update day or time even if using the simple calendar buttons to progress an hour or a day. Meanwhile, the smalltime window right next to it successfully updates on each click within simple calendar in live sync.

It's as if the update script/event/hook was lost somewhere. So there are no updates except for the scheduled ones that depend on the setting within here (2nd from bottom, update frequency):

Ideally, we could enter 0 to have it update live. Instead of only when the time progression counter ticks.

[rapus95]

After diving into it a bit more, I guess there's the problem:

  this.setDateTime(parsedDate, { updateApp: false, sync: false, save: GameSettings.IsGm() && SC.primary });

https://github.com/vigoren/foundryvtt-simple-calendar/blob/main/src/classes/calendar/index.ts#L1240

  this.setDateTime(parsedDate, { updateApp: false, sync: false, save: GameSettings.IsGm() && SC.primary });

https://github.com/vigoren/foundryvtt-simple-calendar/blob/main/src/classes/calendar/index.ts#L1253

In both of these lines, we have updateApp: false which simply never updates the ui as far as I understand it.

While the time progression runs, this line is executed:

  this.setDateTime(parsedDate, {
    updateApp: this.time.updateFrequency * this.time.gameTimeRatio !== changeAmount,
    sync: false,
    save: false,
    bypassPermissionCheck: true
  });

https://github.com/vigoren/foundryvtt-simple-calendar/blob/main/src/classes/calendar/index.ts#L1220-L1225
which sometimes evaluates to true in the argument of updateApp.

Thus, the proposal is: change both updateApp: false lines to updateApp: true.

[rapus95]

Having edited both lines to true with Chrome Dev Tools, made the clock update again. But then deleting my changes, refreshing the page and even trying in an incognito browser, it kept working... Which is weird.

So I'm back at the beginning and have no clue what the problem is.

[vigoren]

I will be digging into this issue, and a few others, over the weekend when I have some free time.

[vigoren]

I have found the issue and will be releasing a fix for it in a couple of days (after I fix up a few other things)

[vigoren]

This has been fixed in version 2.4.8!