Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace usage of ref(markRaw(...)) width shallowRef(...) #130

Merged
merged 1 commit into from
Jun 13, 2024
Merged

feat: replace usage of ref(markRaw(...)) width shallowRef(...) #130

merged 1 commit into from
Jun 13, 2024

Conversation

pdanpdan
Copy link
Collaborator

@brillout
Copy link
Member

Neat, much cleaner. Can you remove feat: ? Or replace it with perf: if you believe it's a performance boost. The only goal of the prefix is to generate CHANGELOG.md entries.

@pdanpdan
Copy link
Collaborator Author

It's more chore:

@brillout
Copy link
Member

Yea, let's not add any prefix then.

@brillout
Copy link
Member

We don't use chore: .

@pdanpdan
Copy link
Collaborator Author

done

@brillout brillout merged commit 827c5de into vikejs:main Jun 13, 2024
3 checks passed
@brillout
Copy link
Member

✨

@pdanpdan pdanpdan deleted the feature/shallow-ref branch June 13, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdanpdan @brillout