Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wild card matching in .goduignore #19

Open
nochso opened this issue Jan 8, 2017 · 4 comments
Open

Wild card matching in .goduignore #19

nochso opened this issue Jan 8, 2017 · 4 comments

Comments

@nochso
Copy link

nochso commented Jan 8, 2017

Just thought I'd open an issue for what's mentioned in the readme. This should behave similar to .gitignore.

Perhaps have a look at gobwas/glob. It should allow matching directories and file names.

@viktomas
Copy link
Owner

viktomas commented Jan 8, 2017

Thanks @nochso, I think that when I was implementing godu I hugely underestimated the canonical filepath and its accessibility throughout the code. That's something that needs to be solved before this (and #14) can be implemented.

@nochso
Copy link
Author

nochso commented Jan 8, 2017

I usually stick to path/filepath which has worked fine so far. Then again, I'm not entirely sure what you mean.

@viktomas
Copy link
Owner

godu is now prepared for the functionality to be implemented here: https://github.com/viktomas/godu/blob/master/core/file_walker.go#L43

It is free for taking if someone wants to implement the logic. Please thumb up this comment if you'd like to have more advanced .goduignore parsing and matching.

@viktomas
Copy link
Owner

viktomas commented May 2, 2020

The whole logic of .goduignore file is now stored in here https://github.com/viktomas/godu/blob/master/ignore.go#L37-L47 The wildcard matching could be implemented there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants