Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "pip" and "quality" embed parameters in oEmbedParameters #820

Open
mikeamarkey opened this issue Apr 9, 2022 · 1 comment
Open

Comments

@mikeamarkey
Copy link

mikeamarkey commented Apr 9, 2022

I'm currently planning on adding some missing Player method definitions to the @types/vimeo__player package, and when I was comparing the Embed options of the official documentation (as well as the README of this repository), I noticed that the following embed parameters are missing in oEmbedParameters:

  • pip
  • quality

Is this intentional? If not, could they be added (or could I create a PR adding them?)

Thanks! 👋

@bdougherty
Copy link
Contributor

As far as I know, this is not intentional. For what it's worth, they can still be used as part of the options object, just not as data attributes without being in the array. But we are happy to accept a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants