You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm currently planning on adding some missing Player method definitions to the @types/vimeo__player package, and when I was comparing the Embed options of the official documentation (as well as the README of this repository), I noticed that the following embed parameters are missing in oEmbedParameters:
pip
quality
Is this intentional? If not, could they be added (or could I create a PR adding them?)
Thanks! 👋
The text was updated successfully, but these errors were encountered:
As far as I know, this is not intentional. For what it's worth, they can still be used as part of the options object, just not as data attributes without being in the array. But we are happy to accept a PR!
I'm currently planning on adding some missing Player method definitions to the
@types/vimeo__player
package, and when I was comparing the Embed options of the official documentation (as well as the README of this repository), I noticed that the following embed parameters are missing in oEmbedParameters:pip
quality
Is this intentional? If not, could they be added (or could I create a PR adding them?)
Thanks! 👋
The text was updated successfully, but these errors were encountered: