-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fullscreenchange listener firing twice #926
Comments
Thanks for reporting these issues @bryananthonylewis; I'm able to reproduce both of them. We'll ticket these issues internally and prioritize them for investigation soon. |
Thank you for this response, I appreciate your help! |
Seems to happen for error events as well, any status update yet @rkrishnan8594 ? |
@dlueth can you file a separate issue for that with reproduction steps and example? Thanks. |
I think the issue here is this code sending a message to the player on any full screen change of the parent page Lines 151 to 153 in 8f37159
I think it needs to be a little smarter about sending that message. |
I've been trying to send Google Tag Manager (GTM) stats on our Vimeo player, when it goes fullscreen. The problem is that when the fullscreenchange event gets triggered, it sends 2 GTM event pushes. I've seen a few other people posting about similar issues with events firing multiple times and haven't found a solution yet. Any help would be great.
Expected Behavior
Only run 1 time when fullscreenchange is triggered.
Actual Behavior
Runs 2 times
Steps to Reproduce
https://codepen.io/bryanlewis/pen/bGmoPpY
I also noticed it runs for each player on the same page. The codepen example shows when you go fullscreen with 1 player the fullscreenchange happens on both players.
The text was updated successfully, but these errors were encountered: