What is the point of all the useless if statements in the codebase?

[jack-worman]

What is the point of writing code like this:

if (IssueBuffer::accepts(new NoEnumProperties(
    'Enums cannot have properties',
    new CodeLocation($this, $prop),
    $fq_class_name
))) {
    // fall through
}

When it can be written without the if statement:

IssueBuffer::accepts(new NoEnumProperties(
    'Enums cannot have properties',
    new CodeLocation($this, $prop),
    $fq_class_name
));

[psalm-github-bot]

Hey @jack-worman, can you reproduce the issue on https://psalm.dev ?

[jack-worman]

I see #7020, so I assume that was just an old practice.

[weirdan]

It is.