Issues report depends on --threads

[SCIF]

Just got different results using v5.4.0:

php ./vendor/bin/psalm --no-cache --threads=1:

------------------------------
                              
       No errors found!       
                              
------------------------------
3236 other issues found.

php ./vendor/bin/psalm --no-cache --threads=2:

------------------------------
1 errors found
------------------------------
3241 other issues found.

php ./vendor/bin/psalm --no-cache --threads=4:

------------------------------
1 errors found
------------------------------
3243 other issues found.

A few observations:

1. Total issue counter differs for 2 and 4 threads. But it differs exactly for the number of threads (3243-3241=2, 4-2=2)
2. The error found by psalm was a deprecation notice present in the file 8 times, but in baseline file it was just 7 occurances of them. Looks like multithreaded run shows more correct results (which is weird and not expected tbh)

The text of an issue shown in the report:

ERROR: DeprecatedClass - app/Repository/MyModelRepository.php:160:16 - Class App\Models\MyModel is marked as deprecated (see https://psalm.dev/098)
     * @return Collection<array-key, MyModel>

[psalm-github-bot]

Hey @SCIF, can you reproduce the issue on https://psalm.dev ?

[SCIF]

Ok, something weird is continue to happen. I ran --threads=4 --update-baseline and then --threads=1 shows me issues which appear for threads<4 runs.

[orklah]

Could you check again? There have been work related to threads that could have resolved the issue

[SCIF]

Could you check again? There have been work related to threads that could have resolved the issue

I'll leave the message here once will test and make sure current behavior is correct. For now psalm shows too much warnings on our codebase so we are in process of figuring out what's happening. Give us a week or so