[BUG] Install & update scripts out of sync for BRANCH variable #117
Comments
|
Could you test the new version? |
Not successful Believe the problem now is that since the FIRST_INSTALL doesn't write out a BRANCH 100% of the time, the UPDATE script cannot find to change it & the INFO notification is simply a fall through instead of proper validation IOW: The FIRST_INSTALL & UPDATE scripts should always write out a proper version into the BRANCH variable in the sdtdserver.cfg file (my $.02) Fresh install using STABLE branch of 7D2D: UPDATE to 'latest_experimental' attempt: Install:
Update:
|
|
I note the FIRST_INSTALL script doesn't ensure the BRANCH variable is created if/when STABLE/PUBLIC (there's no line 43 for the STABLE/PUBLIC check) & the UPDATE script (IMO) shouldn't blank out the BRANCH if/when STABLE/PUBLIC is wanted. If STABLE/PUBLIC is there & STABLE/PUBLIC used in the compose file, no update will be done anyway. Again, just my $.02 :) Valid svr code DEPOTS
|
|
Possible fix for 1st_install & update (after reading more of the LinuxGSM & SteamCMD documentation, seems an empty branch defaults to STABLE) |
|
Did you pull the latest image?, because at this issue #115 he was able to update. |
No success still (I believe #115 would be 'fixed' via fresh start as 20.5 IS the new STABLE (default install)) I ran MODE0 to install the STABLE instance of 7D2D. Then ran MODE2 using the 'testing_trunk' depot (https://steamdb.info/app/251570/depots/). No BRANCH written into the LGSM CONFIG file (folders & files are present), as it failed to parse the path: My COMPOSE file:
|
|
I will check it tomorrow today it's my birthday and I'm gonna be out :) |
Happy b-day & have a good time (offline) :D |
Your UPDATE script doesn't have a BASEPATH variable like FIRST_INSTALL |
|
Could you test:
|
|
NOT quite 100% The CONFIG though didn't write out correctly:
All the LOGS+ |
|
UPDATE script (& FIRST_INSTALL too, no?) on non-STABLE/PUBLIC isn't escaping the quotations? Line 19: sed -i 's/branch=.*/branch="$VERSION"/' $LSGMSDTDSERVERCFG |
It should be updated with last commit, I forgot to change that line when doing the changes :( Pull latest version and should be working |
|
Same. Mode 0 BETA (1st test attempt). SDTDSERVER.CFG: |
|
UPDATE script, line 21 (& same in FIRST_INSTALL) needs escaping as well. Quick shell test gives me the expected outcome:
Maybe default to an empty BRANCH in the CFG (branch="") & skip the whole check all around :P |
|
Fixed, I have tested and was working without problem |
Same would be needed for same area/line in FIRST_INSTALL too, no? I'll give it a whirl when I get a chance. TY |
Edited and released a new version |
|
Initial run 1:
Initial run 2:
Seems to be working as expected now, TY. |
Thanks for testing and for the help :) |
Happy to assist & apprec. the container |
Describe the bug
BRANCH variable used for SteamCMD is generated in a different file than it's read from during the update process
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Should pull down/verify the correct VERSION requested
Screenshots
If applicable, add screenshots to help explain your problem.
Versions:
Docker/Docker-compose
version: "3"
services:
7dtdserver:
image: vinanrra/7dtd-server # https://github.com/vinanrra/Docker-7DaysToDie
container_name: 7dtdserver
environment:
- ALLOC_FIXES=NO # Optional - Install Allocs Fixes
- ALLOC_FIXES_UPDATE=NO # Optional - Update Allocs Fixes, depending of your 7 days to die version, on server install
- BACKUP=YES # Optional - Backup server at 5 AM
- MONITOR=YES # Optional - Keeps server up if crash
- PUID=1000
- PGID=1000
- START_MODE=3 # REQUIRED - Change between START MODES
#
# Start Modes
#
# 0 Install server
# 1 Start server
# 2 Update server
# 3 Update server and start, useful if you have already a 7 Days To Die server installed
# 4 Backup server and STOP the container
#
- TEST_ALERT=YES # Test alerts at start of server
- TimeZone=America/New_York
- VERSION=stable # Change between 7 days to die versions
# 'stable' or 'latest_experimental' or...
# https://steamdb.info/app/251570/depots/
volumes:
- /nas/Data/steam/[Games]/7days2die/svr:/home/sdtdserver/serverfiles/ # 7DaysToDie server config files.
- /nas/Data/steam/[Games]/7days2die/userData:/home/sdtdserver/.local/share/7DaysToDie/ # 7DaysToDie saves, where maps are store.
- /nas/Data/steam/LGSM/Logs:/home/sdtdserver/log/ # 7DaysToDie server log files.
- /nas/Data/steam/LGSM/Backup:/home/sdtdserver/lgsm/backup/ # 7DaysToDie server backups files.
- /nas/Data/steam/LGSM/Config:/home/sdtdserver/lgsm/config-lgsm/sdtdserver/ # LGSM config files.
- /nas:/media
ports:
- 80:80/tcp # EAC/EOS (testing)
- 443:443/tcp # EAC/EOS (testing)
- 26900:26900/tcp # PC
- 26900-26905:26900-26905/udp # PC (added few 'extra' ports to CYA)
- 27015-27050:27015-27050/udp # Valve (server registration)
# [added more ports via https://7dtd.illy.bz/wiki/Ports]
- 1935:1935/tcp # Playstation
- 3478-3480:3478-3480/udp # Playstation
- 3074:3074/tcp # X-Box
- 3074:3076:3074:3076/udp # X-Box
# (all the above via https://portforward.com/7-days-to-die/)
- 8083:8083/tcp # OPTIONAL WEBADMIN [NOTE: match server's CFG file]
- 8084:8084/tcp # OPTIONAL TELNET [NOTE: match server's CFG file]
- 8085:8085/tcp # OPTIONAL WEBSERVER https://7dtd.illy.bz/wiki/Server%20fixes
- 8087:8087/tcp # OPTIONAL WEBSERVER https://github.com/dmustanger/7dtd-ServerTools
restart: unless-stopped # NEVER USE WITH START_MODE=0, 2 or 4
# "no"
# always
# on-failure
# unless-stopped
#
# https://developer.valvesoftware.com/wiki/SteamCMD
Additional context
FIRST_INSTALL.SH will create/update (LSGMSDTDSERVERCFG=${BASEPATH}/lgsm/config-lgsm/sdtdserver/sdtdserver.cfg) & put the BRANCH variable within.
SERVER_UPDATE.SH on the other hand attempts to read the BRANCH variable from '/home/sdtdserver/lgsm/config-lgsm/sdtdserver/common.cfg'
The text was updated successfully, but these errors were encountered: